This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unused Settings::ToString. #8642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used in some embedder implementations. But that was a while ago.
jason-simmons
approved these changes
Apr 18, 2019
liyuqian
approved these changes
Apr 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2019
This was referenced Apr 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2019
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Apr 21, 2019
flutter/engine@ca31a7c...206cab6 git log ca31a7c..206cab6 --no-merges --oneline 206cab6 Roll src/third_party/skia cc5d3e09e394..1c0b05afdef8 (14 commits) (flutter/engine#8654) 1fe3279 Cleanup references to FLX archives from the engine. (flutter/engine#8653) 6257dfe Add factory methods to FileMapping that make it easy to create common mappings. (flutter/engine#8652) 5fed725 Roll buildroot to 380d0ed (flutter/engine#8649) eaa0e9c Roll src/third_party/skia e5763787f920..cc5d3e09e394 (3 commits) (flutter/engine#8651) 7e37080 Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (flutter/engine#8643) 30c23e6 Roll src/third_party/skia e8a33ec6d084..e5763787f920 (1 commits) (flutter/engine#8650) 8f0af31 Roll src/third_party/skia 8cdae55bf1ac..e8a33ec6d084 (3 commits) (flutter/engine#8648) 25c33dc Roll src/third_party/skia 9b67802a4cd0..8cdae55bf1ac (1 commits) (flutter/engine#8647) 1e5f59d Reland &flutter#34;Remove DartSnapshotBuffer and dry up snapshot resolution logic&flutter#34;. (flutter/engine#8645) 4ead9c8 Remove unused Settings::ToString. (flutter/engine#8642)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
liyuqian
added a commit
to flutter/flutter
that referenced
this pull request
Apr 22, 2019
flutter/engine@ca31a7c...206cab6 git log ca31a7c..206cab6 --no-merges --oneline 206cab6 Roll src/third_party/skia cc5d3e09e394..1c0b05afdef8 (14 commits) (flutter/engine#8654) 1fe3279 Cleanup references to FLX archives from the engine. (flutter/engine#8653) 6257dfe Add factory methods to FileMapping that make it easy to create common mappings. (flutter/engine#8652) 5fed725 Roll buildroot to 380d0ed (flutter/engine#8649) eaa0e9c Roll src/third_party/skia e5763787f920..cc5d3e09e394 (3 commits) (flutter/engine#8651) 7e37080 Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (flutter/engine#8643) 30c23e6 Roll src/third_party/skia e8a33ec6d084..e5763787f920 (1 commits) (flutter/engine#8650) 8f0af31 Roll src/third_party/skia 8cdae55bf1ac..e8a33ec6d084 (3 commits) (flutter/engine#8648) 25c33dc Roll src/third_party/skia 9b67802a4cd0..8cdae55bf1ac (1 commits) (flutter/engine#8647) 1e5f59d Reland "Remove DartSnapshotBuffer and dry up snapshot resolution logic". (flutter/engine#8645) 4ead9c8 Remove unused Settings::ToString. (flutter/engine#8642) TBR: @cbracken
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Apr 22, 2019
This reverts commit 4ead9c8. Reland tracked in flutter/flutter#31433.
chinmaygarde
added a commit
that referenced
this pull request
Apr 22, 2019
This reverts commit 4ead9c8. Reland tracked in flutter/flutter#31433.
eggfly
pushed a commit
to eggfly/engine
that referenced
this pull request
Mar 15, 2022
This was used in some embedder implementations. But that was a while ago.
fluttergithubbot
pushed a commit
that referenced
this pull request
Mar 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used in some embedder implementations. But that was a while ago.