Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll to branched dart sdk with two more hotfixes for flutter 1.5.4. #8790

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

aam
Copy link
Member

@aam aam commented Apr 30, 2019

Cherry-picks for flutter/flutter#29007 and VERSION file bump.

@aam aam requested review from Hixie and tvolkert April 30, 2019 19:16
@aam
Copy link
Member Author

aam commented Apr 30, 2019

cc @athomas

@aam aam changed the title Roll to branched dart sdk with two more hotfixes for fluter 1.5.4. Roll to branched dart sdk with two more hotfixes for flutter 1.5.4. Apr 30, 2019
@tvolkert
Copy link
Contributor

Looks like this needs a license signature update

@aam
Copy link
Member Author

aam commented Apr 30, 2019

Looks like this needs a license signature update

Done

@tvolkert
Copy link
Contributor

The Dart version bump to 2.3.0 could be problematic because it'll mean that Flutter v1.5.4-hotfix.[n] will report a newer Dart version than v1.5.5-v1.y.z (where y and z are probably already bounded, but I didn't take the time to look them up). If any of those versions ever make it to stable, it'll potentially mess with the SDK constraints of pub packages.

@aam
Copy link
Member Author

aam commented Apr 30, 2019

The Dart version bump to 2.3.0 could be problematic because it'll mean that Flutter v1.5.4-hotfix.[n] will report a newer Dart version than v1.5.5-v1.y.z

VERSION update should not change version dart sdk that flutter reports(has been reporting). dart sdk built in flutter doesn't use VERSION file - instead it looks up value from the tag.

@tvolkert
Copy link
Contributor

Gotcha - what's the significance of the VERSION file bump?

@aam
Copy link
Member Author

aam commented Apr 30, 2019

Gotcha - what's the significance of the VERSION file bump?

Hm, not sure... @Hixie requested it, need to check with him.

@aam aam merged commit 52c7a1e into flutter:v1.5.4-hotfixes Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants