This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change the virtual display size restriction to warning #9110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes: flutter/flutter#33290 - This is so we don't block usecases where users show the platform view partially. - flutter/flutter#31990 should address this issue more broadly.
amirh
approved these changes
May 29, 2019
| @@ -422,11 +422,11 @@ private static PointerCoords parsePointerCoords(Object rawCoords, float density) | |||
| private void validateVirtualDisplayDimensions(int width, int height) { | |||
| DisplayMetrics metrics = context.getResources().getDisplayMetrics(); | |||
| if (height > metrics.heightPixels || width > metrics.widthPixels) { | |||
| String error = "Creating a virtual display of size: " | |||
| String message = "Creating a virtual display of size: " | |||
| + "[" + width + ", " + height + "]" | |||
| + " is not supported. It is larger than the device screen size: " | |||
There was a problem hiding this comment.
We should probably update the message(it is supported, up to a limit...)
There was a problem hiding this comment.
@amirh How can we solve this issue ? And we should use flutter dev or stable ?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 30, 2019
flutter/engine@4c4c0f8...fa9b5bd git log 4c4c0f8..fa9b5bd --no-merges --oneline fa9b5bd Reduce pipeline depth when GPU and Platform are same thread (flutter/engine#9132) d479412 Change the virtual display size restriction to warning (flutter/engine#9110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
* Change the virtual display size restriction to warning - Fixes: flutter/flutter#33290 - This is so we don't block usecases where users show the platform view partially. - flutter/flutter#31990 should address this issue more broadly. * Fix error message
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
flutter/engine@4c4c0f8...fa9b5bd git log 4c4c0f8..fa9b5bd --no-merges --oneline fa9b5bd Reduce pipeline depth when GPU and Platform are same thread (flutter/engine#9132) d479412 Change the virtual display size restriction to warning (flutter/engine#9110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
|
how can i change it and override the method |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: [Android] Full screen Platform View fails on fullscreen devices with notch flutter#33290
This is so we don't block usecases where users show the platform
view partially.
[platform_views] VirtualDisplay need only be the worst case size of the screen flutter#31990 should address this
issue more broadly.