This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make flow layers' attributes immutable #9176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
force-pushed
the
immutable_layer
branch
2 times, most recently
from
7858a50 to
704de74
Compare
Related issue: flutter/flutter#33807 We still need to make layers' children immutable for full immutability. That will require us to change the SceneBuilder API to build the layer bottom up instead of top down (post-order traversal instead of pre-order traversal).
chinmaygarde
approved these changes
Jun 10, 2019
yjbanov
approved these changes
Jun 10, 2019
| ClipPathLayer::ClipPathLayer(Clip clip_behavior) | ||
| : clip_behavior_(clip_behavior) { | ||
| ClipPathLayer::ClipPathLayer(const SkPath& clip_path, Clip clip_behavior) | ||
| : clip_path_(clip_path), clip_behavior_(clip_behavior) { |
There was a problem hiding this comment.
Does this deeply copy the path? Is that fast enough?
There was a problem hiding this comment.
I think SkPath is copy on write. In any case, this is no slower than our old setPath.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 10, 2019
flutter/engine@36b7123...f3ab2e4 git log 36b7123..f3ab2e4 --no-merges --oneline f3ab2e4 Roll src/third_party/skia 5ec1b8ff3f45..cb1adb40d0f3 (10 commits) (flutter/engine#9258) b622d43 Make flow layers' attributes immutable (flutter/engine#9176) 259d334 Reland "Keyboard support for embedded Android views. (#9203) (flutter/engine#9257) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
For flutter/flutter#33807 We still need to make layers' children immutable for full immutability. That will require us to change the SceneBuilder API to build the layer bottom up instead of top down (post-order traversal instead of pre-order traversal).
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
flutter/engine@36b7123...f3ab2e4 git log 36b7123..f3ab2e4 --no-merges --oneline f3ab2e4 Roll src/third_party/skia 5ec1b8ff3f45..cb1adb40d0f3 (10 commits) (flutter/engine#9258) b622d43 Make flow layers&flutter#39; attributes immutable (flutter/engine#9176) 259d334 Reland &flutter#34;Keyboard support for embedded Android views. (flutter#9203) (flutter/engine#9257) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#33807
We still need to make layers' children immutable for full immutability.
That will require us to change the SceneBuilder API to build the layer
bottom up instead of top down (post-order traversal instead of pre-order
traversal).