When running in AOT modes create a flutter_assets directory that can be used as the bundle path #9306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used as the bundle path The engine RunBundleAndSnapshotFromLibrary API expects a bundle path directory containing the application's assets. If the Android embedding is using AOT ELF library packaging and does not need to extract assets, then create an empty directory at the bundle path. Fixes flutter/flutter#34287
tvolkert
approved these changes
Jun 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2019
…hat can be used as the bundle path (flutter/engine#9306)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2019
flutter/engine@67aadb6...209250d git log 67aadb6..209250d --no-merges --oneline 209250d When running in AOT modes create a flutter_assets directory that can be used as the bundle path (flutter/engine#9306) 1593838 Handle Fuchsia SDK in license tool + roll SDK (flutter/engine#9302) e66118b Roll src/third_party/skia 81756e4cae95..b9416caa367a (6 commits) (flutter/engine#9305) 7bb5b9a Wire up Swiftshader based OpenGL ES unit-tests on hosts. (flutter/engine#9264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 13, 2019
…be used as the bundle path (flutter#9306) The engine RunBundleAndSnapshotFromLibrary API expects a bundle path directory containing the application's assets. If the Android embedding is using AOT ELF library packaging and does not need to extract assets, then create an empty directory at the bundle path. Fixes flutter/flutter#34287
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
flutter/engine@67aadb6...209250d git log 67aadb6..209250d --no-merges --oneline 209250d When running in AOT modes create a flutter_assets directory that can be used as the bundle path (flutter/engine#9306) 1593838 Handle Fuchsia SDK in license tool &flutter#43; roll SDK (flutter/engine#9302) e66118b Roll src/third_party/skia 81756e4cae95..b9416caa367a (6 commits) (flutter/engine#9305) 7bb5b9a Wire up Swiftshader based OpenGL ES unit-tests on hosts. (flutter/engine#9264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine RunBundleAndSnapshotFromLibrary API expects a bundle path directory
containing the application's assets. If the Android embedding is using
AOT ELF library packaging and does not need to extract assets, then create an
empty directory at the bundle path.
Fixes flutter/flutter#34287