Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Android Embedding Refactor PR33: Clean up FlutterJNI. #9354

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Android Embedding Refactor PR33: Clean up FlutterJNI. #9354

merged 1 commit into from
Jun 18, 2019

Conversation

matthew-carroll
Copy link
Contributor

Android Embedding Refactor PR33: Clean up FlutterJNI.

This PR:

  • Removes temporary comments intended to help during the embedding refactor
  • Groups FlutterJNI methods based on their behavior
  • Adds some missing JavaDocs

There should not be any behavioral changes in this PR.

mklim
mklim approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 36f18b0 into flutter:master Jun 18, 2019
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
3c579cb 
…#25533). (flutter/engine#9354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
663641c 
…#25533). (flutter/engine#9354)
This was referenced Jun 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
3f7446d 
…#25533). (flutter/engine#9354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
9b90be6 
…#25533). (flutter/engine#9354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
a13a526 
…#25533). (flutter/engine#9354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
e2f9da3 
…#25533). (flutter/engine#9354)
This was referenced Jun 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
8440189 
…#25533). (flutter/engine#9354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2019
@engine-flutter-autoroll
36f18b0 Android Embedding Refactor PR33: Clean up FlutterJNI (flutter…
bce7c46 
…#25533). (flutter/engine#9354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tvolkert tvolkert Awaiting requested review from tvolkert

1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthew-carroll @mklim @googlebot