There are wrong de-CH translations in package/flutter-localization

[rekire]

Is there an existing issue for this?

• I have searched the existing issues
• I have read the guide to filing a bug

Steps to reproduce

I found in MaterialLocalizationDe a translation "TBD" and some clear translation errors like there is no ß in de-CH

Expected results

No TBD translations in German and no ß letters in de-CH.

Actual results

There is a translation "TBD" which seems to be wrong. I also found wrong translations for de-CH (basically de-DE just in upper case) and some clear translation errors like there is no ß in de-CH

Code sample

Code sample

[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs

[Paste your logs here]

Flutter Doctor output

Doctor output

[Paste your output here]

[goderbauer]

FYI @HansMuller

[rekire]

Any updates here?

Might be not the right place here, but is a test required for fixing this?

[goderbauer]

That it says TBD in the translation files is definitely not great. We probably need some kind of a guard to not release with incomplete translations like that. @HansMuller or @godofredoc Any idea where in the release process we could guard against this?

[rekire]

Just FYI there are more such wrong translations. I just cannot translate those languages and I think it doesn't make sense to use some automatic translation tools.

% grep TBD packages/flutter_localizations/lib/src/l10n/*.arb | wc -l
65

Those "TBD" translations are from 2018

[HansMuller]

The problem appears to be isolated to the translation for remainingTextFieldCharacterCountZero which is used in packages/flutter/lib/src/material/text_field.dart (added in 2018: #24183):

    // Handle a real maxLength (positive number)
    if (widget.maxLength! > 0) {
      // Show the maxLength in the counter
      counterText += '/${widget.maxLength}';
      final int remaining = (widget.maxLength! - currentLength).clamp(0, widget.maxLength!); // ignore_clamp_double_lint
      semanticCounterText = localizations.remainingTextFieldCharacterCount(remaining);
    }

The remainingTextFieldCharacterCount method is defined in packages/flutter_localizations/lib/src/material_localizations.dart:

  String remainingTextFieldCharacterCount(int remaining) {
    return intl.Intl.pluralLogic(
      remaining,
      zero: remainingTextFieldCharacterCountZero,
      one: remainingTextFieldCharacterCountOne,
      two: remainingTextFieldCharacterCountTwo,
      many: remainingTextFieldCharacterCountMany,
      few: remainingTextFieldCharacterCountFew,
      other: remainingTextFieldCharacterCountOther,
      locale: _localeName,
    ).replaceFirst(r'$remainingCount', formatDecimal(remaining));
  }

Which delegates to https://api.flutter.dev/flutter/intl/Intl/pluralLogic.html and treats null translations the same as other. The remainingTextFieldCharacterCountZero message is considered "optional", so null (but not 'TBD') is OK.

The "TBDs" were added in #21029 and (presumably) it was assumed that they'd be replaced with the real translations when they became available. However because TextFieldCharacterCountZero is optional the translation was never created.

FTR: the (Google internal) message ID for remainingTextFieldCharacterCountZero is 8620340609350511875 and can be found at (Google internal link) localizer.google.com/messages/searchresults?message-id=8620340609350511875&text-search-option=search-on-source-content&text-search-option=search-on-translations&project-id=Flutter

[rekire]

@HansMuller what is about my PR #136091 which corrects some translations? Is it worthless since I cannot edit the Google internal message IDs?