Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable unawaited_futures analysis option #5793

Closed
danrubel opened this issue Sep 9, 2016 · 4 comments
Closed

enable unawaited_futures analysis option #5793

danrubel opened this issue Sep 9, 2016 · 4 comments
Labels
framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@danrubel
Copy link
Contributor

danrubel commented Sep 9, 2016

Enable the unawaited_futures analysis option in the 2 flutter repo analysis option files and cleanup the generated warnings.
@danrubel danrubel added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 9, 2016
@Hixie Hixie modified the milestone: Flutter 1.0 Sep 12, 2016
@Hixie Hixie added the framework flutter/packages/flutter repository. See also f: labels. label Sep 12, 2016
@Hixie
Copy link
Contributor

Hixie commented Jan 22, 2017

This might be WONTFIX. We rarely await futures and it's not clear it would make the code cleaner. Most of our futures are harmless to ignore (e.g. the ones from animation controllers), and most can never throw errors so awaiting them to catch the error doesn't really help.

@eseidelGoogle eseidelGoogle modified the milestones: No Milestone Necessary, 5: Make Hixie proud Feb 3, 2017
@tvolkert
Copy link
Contributor

FYI, recent updates to package:test have made this even less likely to provide any value -- dart-lang/test#529 (comment)

@danrubel
Copy link
Contributor Author

Closing this as WONTFIX makes sense to me.

@tvolkert tvolkert mentioned this issue Feb 15, 2017
Merged
tvolkert added a commit that referenced this issue Feb 15, 2017
@tvolkert
Update analysis options (#8203)
7b8705f 
Fixes #7166

Also cleans up from an aborted attempt at #5793
@xster xster mentioned this issue Jun 15, 2017
Closed
@rmacnak-google rmacnak-google mentioned this issue Jul 19, 2018
Merged
rmacnak-google added a commit that referenced this issue Jul 19, 2018
@rmacnak-google
Roll engine to 55b423f.
2a058d3 
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793)
3054f31 Add touch events to the platform views method channel API. (#5796)
91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799)
1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)
8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797)
e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795)
624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)
16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)
3fe63fd Add presubmit check for engine to flutter roll (#5790)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this issue Jul 19, 2018
@rmacnak-google
Roll engine to 55b423f.
0fef30a 
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (flutter#5793)
3054f31 Add touch events to the platform views method channel API. (flutter#5796)
91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745)" (flutter#5799)
1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745)
8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794)" (flutter#5797)
e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792)" (flutter#5795)
624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792)
16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794)
3fe63fd Add presubmit check for engine to flutter roll (flutter#5790)
@dnfield dnfield mentioned this issue May 18, 2021
Merged
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hixie @danrubel @eseidelGoogle @tvolkert