Enable hot mode by default. --no-hot disables it

[johnmccutchan]

@eseidelGoogle @sethladd

[sethladd]

How does this impact our internal build system? (if at all)

[yjbanov]

Could you please test dev/benchmarks/complex_layout with the following commands?

# This command should exit automatically immediately after the app starts and
# it should print startup metrics to the console. If it runs in the resident mode
# then something's wrong
flutter run --profile --trace-startup

# This command just checks that driver tests still function after this change
flutter drive --profile --trace-startup -t test_driver/scroll_perf.dart

Thanks.

[sethladd]

Closes #5280

[eseidelGoogle]

I don't know how to evaluate this change. I'm suuuuuper excited to see it. Just no clue how to weigh yes/no.

[Hixie]

I support this change but we should make sure we test hot reload so it doesn't break again. (Ahem.)

[eseidelGoogle]

Does the Atom plugin need to know about this change? (to remove the checkbox it has now). @devoncarew

Related: Will current atom break if it keeps specifying --hot, or will that be silently ignored?

[devoncarew]

I'll double check, but I believe the logic is written to go by what the daemon protocol returns to us when we launch an app, not by what we send in as the setting.

[johnmccutchan]

@yjbanov --profile mode doesn't support hot mode so those two commands will still use the existing runner.

@Hixie I have a benchmark that can act as an integration test of hot reload and hot restart.

@eseidelGoogle I'll hold off on pulling the switch until you give me the OK. I created this CL to kick start this conversation.

[eseidelGoogle]

I suspect we should land this on a Monday AM, instead of a Friday PM. But
honestly I'm hugely in favor of this idea. You have my support. I'd like
us to try and fail and rollout if needed. So lgtm, just don't let that
override others.

Please communicate this to at least the internal list once you've landed.
Thanks!

On Fri, Sep 9, 2016 at 2:51 PM, John McCutchan notifications@github.com
wrote:

@yjbanov https://github.com/yjbanov --profile mode doesn't support hot
mode so those two commands will still use the existing runner.

@Hixie https://github.com/Hixie I have a benchmark that can act as an
integration test of hot reload and hot restart.

@eseidelGoogle https://github.com/eseidelGoogle I'll hold off on
pulling the switch until you give me the OK. I created this CL to kick
start this conversation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#5794 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALTvi8VrzdA3LZv8le2lUltsKh7BhFDkks5qodTmgaJpZM4J5ZSz
.

[johnmccutchan]

PTAL. I'd like to land this today and see what starts to burn.

[sethladd]

Yes, let's turn this on.

[dragostis]

LGTM.

[johnmccutchan]

Just finishing the benchmark / integration test CL before landing this.

[coveralls]

Coverage remained the same at 71.675% when pulling d6f9afc on johnmccutchan:enable_hot_mode_by_default into 157ffaa on flutter:master.

[eseidelGoogle]

I'm very confused as to why @coveralls is commenting on a 2 year old PR.