Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter build is returning zero, should return not zero ? #5797

Open
sethladd opened this issue Sep 9, 2016 · 5 comments
Open

flutter build is returning zero, should return not zero ? #5797

sethladd opened this issue Sep 9, 2016 · 5 comments
Labels
P3 Issues that are less important to the Flutter project team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - command line usability review

Comments

@sethladd
Copy link
Contributor

sethladd commented Sep 9, 2016

flutter build doesn't do anything other than print the help. We might not want to return zero there. Instead, I'd expect some non-zero code.

For example, this will run the second command, which I didn't expect:

flutter build && flutter install

The second command should not run because the first was not successful, however the first command returned zero.
@sethladd sethladd added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 9, 2016
@Hixie
Copy link
Contributor

Hixie commented Sep 9, 2016

build should probably default to whatever we would build if we were using flutter run.
also, install should imply build anyway.

@Hixie Hixie modified the milestone: Flutter 1.0 Sep 12, 2016
@eseidelGoogle
Copy link
Contributor

eseidelGoogle commented Feb 8, 2017 •
edited

This is definitely a real bug (note that git alone exits with 1, etc.). Probably a very easy fix. I suspect the Build command shouldn't implement run(), not sure. This might also be a bug in package:args.

@Riyuzakii
Copy link

@eseidelGoogle This is my first time on github, and i would like to help fix this bug, if you would be kind enough to guide me through it.

@eseidelGoogle
Copy link
Contributor

@Riyuzakii https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md are possibly helpful? Also, many of our engineers are reachable via gitter.im/flutter/flutter if chat would be helpful.

@Hixie Hixie removed the easy fix label Jan 15, 2018
@rmacnak-google rmacnak-google mentioned this issue Jul 19, 2018
Merged
rmacnak-google added a commit that referenced this issue Jul 19, 2018
@rmacnak-google
Roll engine to 55b423f.
2a058d3 
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793)
3054f31 Add touch events to the platform views method channel API. (#5796)
91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799)
1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)
8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797)
e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795)
624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)
16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)
3fe63fd Add presubmit check for engine to flutter roll (#5790)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this issue Jul 19, 2018
@rmacnak-google
Roll engine to 55b423f.
0fef30a 
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (flutter#5793)
3054f31 Add touch events to the platform views method channel API. (flutter#5796)
91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745)" (flutter#5799)
1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745)
8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794)" (flutter#5797)
e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792)" (flutter#5795)
624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792)
16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794)
3fe63fd Add presubmit check for engine to flutter roll (flutter#5790)
@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@jmagman jmagman added this to Awaiting triage in Tools - command line usability review via automation Jan 13, 2020
@jmagman
Copy link
Member

jmagman commented Jan 13, 2020

See the special-casing of missing build subcommands --> -h instead of throwing a usage error.
39efe4a#diff-328b603a46fc45c62aab3ff4458b99e1R178

@jmagman jmagman moved this from Awaiting triage to Engineer reviewed in Tools - command line usability review Jan 13, 2020
@kf6gpe kf6gpe added the P3 Issues that are less important to the Flutter project label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Stretch Goals Jun 1, 2020
@Hixie Hixie removed this from the [DEPRECATED] Stretch Goals milestone Jun 16, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Stretch Goals milestone Jul 7, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Stretch Goals Jul 22, 2020
@Hixie Hixie removed this from the - milestone Aug 17, 2020
@asashour asashour mentioned this issue Jul 2, 2021
Closed
@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Issues that are less important to the Flutter project team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - command line usability review
  
Engineer reviewed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sethladd @Hixie @jmagman @kf6gpe @eseidelGoogle @Riyuzakii