Fix hot reload #5799
Merged
Fix hot reload #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HansMuller |
I forgot that it was possible for the root view to get marked dirty without getting a new widget. This fixes that case to work.
Hixie
force-pushed
the
hot-reload-broken
branch
from
4c554d6
to
d4df505
Compare
|
fyi @johnmccutchan |
|
LGTM |
rmacnak-google
added a commit
that referenced
this pull request
Jul 19, 2018
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793) 3054f31 Add touch events to the platform views method channel API. (#5796) 91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799) 1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745) 8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797) e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795) 624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792) 16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794) 3fe63fd Add presubmit check for engine to flutter roll (#5790)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (flutter#5793) 3054f31 Add touch events to the platform views method channel API. (flutter#5796) 91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745)" (flutter#5799) 1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5745) 8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794)" (flutter#5797) e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792)" (flutter#5795) 624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (flutter#5792) 16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (flutter#5794) 3fe63fd Add presubmit check for engine to flutter roll (flutter#5790)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that it was possible for the root view to get marked dirty
without getting a new widget. This fixes that case to work.