-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll engine in four steps (do not squash). #19569
Conversation
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793) 3054f31 Add touch events to the platform views method channel API. (#5796) 91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799) 1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745) 8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797) e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795) 624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792) 16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794) 3fe63fd Add presubmit check for engine to flutter roll (#5790)
Folks with unrolled engine commits: @amirh @jonahwilliams @sbaranov @sjindel-google |
I might be out of the loop - what is the plan with this and the other engine rolls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would be nice to list the engine commits this brings in in the PR description: |
Added the rev list. |
@jonahwilliams My plan is to land this as a rebase instead of a squash so the four engine revisions will be tested and benchmarked separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
482469b Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5800)
bb323c1 Revert "Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)" (#5803)
0bf69f0 Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (#5802)
5d0e13a Fix starting isolate directly from CoreJIT snapshot. (#5798)
09ff949 Re-land removal of vmservice_io from release builds. (#5784)
b523ee8 Revert "Switch to Fuchsia's ICU (#5774)" (#5801)
6969549 Switch to Fuchsia's ICU (#5774)
55b423f Ensure assistiveTechnologyEnabled is initialized when the android view is set up (#5793)
3054f31 Add touch events to the platform views method channel API. (#5796)
91c16af Revert "Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)" (#5799)
1a66f89 Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (#5745)
8d046a7 Revert "Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)" (#5797)
e8d172c Revert "Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)" (#5795)
624cf7e Fix Dart 2 reload when running from a snapshot instead of platform.dill. (#5792)
16da471 Roll src/third_party/skia 9e0d7e4072e4..8f8bf8880d9d (32 commits) (#5794)
3fe63fd Add presubmit check for engine to flutter roll (#5790)