dart:ffi changes break customer_testing

[zanderso]

| 00:00 +5: loading /b/s/w/ir/tmp/t/flutter_customer_testing.flutter_cocoon.VWGXMQ/tests/repo_dashboard/test/infrastructure_test.dart
| ../../../../../k/.pub-cache/hosted/pub.dartlang.org/path_provider_windows-0.0.4+3/lib/src/path_provider_windows_real.dart:126:25: Error: The getter 'addressOf' isn't defined for the class 'GUID'.
|  - 'GUID' is from 'package:win32/src/structs.dart' ('../../../../../k/.pub-cache/hosted/pub.dartlang.org/win32-1.7.4/lib/src/structs.dart').
| Try correcting the name to the name of an existing getter, or defining a getter or field named 'addressOf'.
|           knownFolderID.addressOf, KF_FLAG_DEFAULT, NULL, pathPtrPtr);
|            

The repo_dashboard package of cocoon depends on localstorage which depends on an umigrated version of path_provider which uses the deprecated dart:ffi APIs.

This is blocking engine -> framework rolls. See: #76110.

Attempting a Dart SDK revert here: flutter/engine#24436

[zanderso]

/cc @stuartmorgan @dcharkes

[stuartmorgan-g]

Capturing from chat: https://github.com/stuartmorgan/cocoon/pull/1/files fixed this failure for me locally.

[zanderso]

Engine rolls into the framework are no longer blocked on this after reverting the Dart SDK rolls, but restarting the rolls of Dart into the Engine are blocked on updating the cocoon pin in flutter/test: flutter/tests#78

[chinmaygarde]

The revert has been made in the Dart SDK. We are waiting on it to roll into the framework.

[dcharkes]

The revert has been made in the Dart SDK. We are waiting on it to roll into the framework.

I did not revert https://dart-review.googlesource.com/c/sdk/+/184463 in the Dart SDK, because of the alternative fix in flutter/tests#78.

Is there a need to revert the commit in the Dart SDK in the mean time?

[zanderso]

No need to revert in the Dart SDK yet. We are waiting on an Engine -> Framework roll that includes the Dart SDK change to verify that the dependency override in the cocoon package is sufficient.