Skip to content

Deprecate these old APIs #116793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Deprecate these old APIs #116793

merged 1 commit into from
Apr 6, 2023

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Dec 9, 2022

Upstream clients have been updated now.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 9, 2022
@Hixie Hixie force-pushed the deprecations branch 2 times, most recently from bcc7bd4 to 0f62a17 Compare December 11, 2022 05:06
@Hixie Hixie force-pushed the deprecations branch 5 times, most recently from 0a92b35 to f10a45b Compare February 17, 2023 21:30
@Hixie Hixie force-pushed the deprecations branch 5 times, most recently from 68d5eb0 to 4636bc2 Compare March 22, 2023 23:32
@goderbauer
Copy link
Member

go_router has been fixed up here (landed): flutter/packages#3599
fix for pigeon has been suggested here (pending feedback): flutter/packages#3600

I'll close my attempt of doing the same thing at #123812.

@Hixie
Copy link
Contributor Author

Hixie commented Mar 31, 2023

Fixes #108327

@goderbauer goderbauer mentioned this pull request Mar 31, 2023
Merged
@Hixie Hixie force-pushed the deprecations branch 2 times, most recently from 2d79423 to f87b973 Compare April 2, 2023 02:19
@goderbauer
Copy link
Member

The pigeon fix rolled in with #124031. I would expect that rebasing this will turn all checks green now.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 4, 2023

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@Hixie Hixie marked this pull request as ready for review April 5, 2023 05:01
@Hixie Hixie force-pushed the deprecations branch 2 times, most recently from cac0bfc to 327d204 Compare April 5, 2023 05:03
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@Hixie Hixie force-pushed the deprecations branch 2 times, most recently from d776cf1 to 65062c3 Compare April 6, 2023 00:17
@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie
Deprecate these old APIs
56eb73d 
Upstream clients have been updated now.
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot merged commit 806c1f8 into flutter:master Apr 6, 2023
This was referenced Apr 6, 2023
Closed
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
806c1f8 Deprecate these old APIs (flutter/flutter#116793)
54cb140
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Hixie @exaby73
Deprecate these old APIs (flutter#116793)
0931402 
Deprecate these old APIs
@goderbauer goderbauer mentioned this pull request May 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
806c1f8 Deprecate these old APIs (flutter/flutter#116793)
b52fb72
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
806c1f8 Deprecate these old APIs (flutter/flutter#116793)
a1e351e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hixie @goderbauer