Skip to content

Unskip #62819 Fixes #12357 #122945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 24, 2023
Merged

Unskip #62819 Fixes #12357 #122945

merged 18 commits into from
Mar 24, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

Closes #12357 now that most platforms report consistent font metrics (except #122066)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 18, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as draft March 20, 2023 06:24
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 24, 2023
Closed
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 24, 2023 04:41
gspencergoog
gspencergoog approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Oh excellent! Thanks for removing those.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2023
@auto-submit auto-submit bot merged commit 482b5f6 into flutter:master Mar 24, 2023
@LongCatIsLooong LongCatIsLooong deleted the unskip-62819 branch March 24, 2023 22:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
6f4016b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
cb63b49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
fd9177e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
7dd6255
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
57f411f
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
c214553
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
482b5f6 Unskip #62819 Fixes #12357 (flutter/flutter#122945)
70e7ba6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libtxt: Text metrics are sometimes wrong (in different ways on different platforms at different sizes)
2 participants
@LongCatIsLooong @gspencergoog