Skip to content

Reland "Fix bug with clicking Copy or Select All within contextMenu" #122973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

acumen1005
Copy link
Contributor

@acumen1005 acumen1005 commented Mar 19, 2023

Reverts #122832

Relands #120081 by skipping a failing test that shouldn't have run on web.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 19, 2023
… github.com:acumen1005/flutter into revert-122832-revert-120081-selection-overlay-issue
@acumen1005 acumen1005 changed the title [WIP]Revert "Revert "Fix bug with clicking Copy or Select All within contextMenu"" Revert "Revert "Fix bug with clicking Copy or Select All within contextMenu"" Mar 19, 2023
@justinmc justinmc changed the title Revert "Revert "Fix bug with clicking Copy or Select All within contextMenu"" Reland "Fix bug with clicking Copy or Select All within contextMenu"" Mar 20, 2023
@justinmc justinmc changed the title Reland "Fix bug with clicking Copy or Select All within contextMenu"" Reland "Fix bug with clicking Copy or Select All within contextMenu" Mar 20, 2023
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for finding the problem and opening a new PR so quick!

@justinmc justinmc requested a review from chunhtai March 20, 2023 17:11
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit e0ea39f into flutter:master Mar 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants