-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Reland "Fix bug with clicking Copy
or Select All
within contextMenu"
#122973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 28 commits into
flutter:master
from
acumen1005:revert-122832-revert-120081-selection-overlay-issue
Mar 20, 2023
Merged
Reland "Fix bug with clicking Copy
or Select All
within contextMenu"
#122973
auto-submit
merged 28 commits into
flutter:master
from
acumen1005:revert-122832-revert-120081-selection-overlay-issue
Mar 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontextMenu (flutter#120081)" (flutter#122832)" This reverts commit 6711411.
… github.com:acumen1005/flutter into revert-122832-revert-120081-selection-overlay-issue
Copy
or Select All
within contextMenu""Copy
or Select All
within contextMenu""
Copy
or Select All
within contextMenu""Copy
or Select All
within contextMenu""
Copy
or Select All
within contextMenu""Copy
or Select All
within contextMenu"
justinmc
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Thanks for finding the problem and opening a new PR so quick!
chunhtai
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122832
Relands #120081 by skipping a failing test that shouldn't have run on web.