Skip to content

Remove 1745 decorative breaks #123259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 22, 2023
Merged

Remove 1745 decorative breaks #123259

merged 17 commits into from
Mar 22, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 22, 2023 •
edited
Loading

Part of #118837.

In Dart 3, the break statement is optional in switch/case. This PR removes them and enforces that with a lint. It also removes all lints that are no longer valid with Dart 3.

Further reading: https://github.com/dart-lang/language/blob/master/accepted/future-releases/0546-patterns/feature-specification.md#implicit-break

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 22, 2023
@goderbauer goderbauer mentioned this pull request Mar 22, 2023
Closed
23 tasks
@goderbauer goderbauer changed the title WIP Remove 1745 decorative breaks Mar 22, 2023
cbracken
cbracken approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm!

dkwingsmt
dkwingsmt reviewed Mar 22, 2023
View reviewed changes
dev/bots/run_command.dart
@@ -113,7 +113,6 @@ Future<Command> startCommand(String executable, List<String> arguments, {
switch (outputMode) {
case OutputMode.print:
print(line);
break;
case OutputMode.capture:
break;
Copy link
Contributor

@dkwingsmt dkwingsmt Mar 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we remove ones like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the case is empty, you still need the break. Otherwise, it would fall-through to the next case.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 22, 2023
@auto-submit auto-submit bot merged commit fda9ecf into flutter:master Mar 22, 2023
@goderbauer goderbauer deleted the lintSyncPost3 branch March 22, 2023 21:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
b692857
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
df751bf
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
f9d17c1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
6bee146
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
b3e33d1
@HansMuller HansMuller mentioned this pull request Mar 24, 2023
Closed
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
0d719d7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
fda9ecf Remove 1745 decorative breaks (flutter/flutter#123259)
ab2212a
@stuartmorgan-g stuartmorgan-g mentioned this pull request Nov 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt left review comments

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goderbauer @cbracken @dkwingsmt