New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readlink -f flag to CocoaPods script to workaround Xcode 14.3 issue #124062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
iOS applications specifically
tool
Affects the "flutter" command-line tool. See also t: labels.
platform-mac
Building on or for macOS specifically
t: xcode
"xcodebuild" on iOS and general Xcode project management
labels
Apr 3, 2023
vashworth
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
christopherfujino
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
platform-ios
iOS applications specifically
platform-mac
Building on or for macOS specifically
t: xcode
"xcodebuild" on iOS and general Xcode project management
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 14.3 (released March 30, 2023) changed the
readlink
symlink behavior to be relative from the script working directory, instead of the relative path of the symlink. A CocoaPods script generated assource="$(readlink "${source}")"
but with the new behavior should besource="$(readlink -f "${source}")"
. CocoaPods updated their script at CocoaPods/CocoaPods#11828, but hasn't yet released it.This caused a failure when archiving/
flutter build ipa
ing iOS or macOS Flutter apps (build seems to succeed):Add a migrator to copy the CocoaPods workaround and update the generated CocoaPods script so that users don't need to update CocoaPods when they update to Xcode 14.3. Only run the migrator when Xcode >=14.3.
Confirmed on this PR:
pod install
pod install
again after the migration does restore the old behavior, but runningflutter build
/run
again will re-run the migrator.Fixes #123890
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.