-
Notifications
You must be signed in to change notification settings - Fork 28.7k
flutter_tool: add and use WebCompilerConfig #124183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
includes subclasses for JS and Wasm Centralizes logic around configuring and applying compiler configuration Migrated all JS logic to (new) JsCompilerConfig Sets the stage for #124177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, but LGTM
f1fe234
to
9d9ba33
Compare
auto label is removed for flutter/flutter, pr: 124183, due to - The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/flutter, pr: 124183, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter_tool: add and use WebCompilerConfig
includes subclasses for JS and Wasm
Centralizes logic around configuring and applying compiler configuration
Migrated all JS logic to (new) JsCompilerConfig
Sets the stage for #124177