Skip to content

Remove references to deprecated ThemeData.primaryColorBrightness #127238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 19, 2023

Description

Removes references to ThemeData.primaryColorBrightness, deprecated in #93396 and subject to remove now because of our deprecation policy.

Related PRs

Tests

  • Removed unneeded tests, removed references.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 19, 2023
@gspencergoog gspencergoog marked this pull request as ready for review May 19, 2023 23:23
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog force-pushed the deprecate_primary_color_brightness branch from e353ba3 to de7c0af Compare May 22, 2023 20:01
@gspencergoog gspencergoog force-pushed the deprecate_primary_color_brightness branch from de7c0af to 1eb2738 Compare May 26, 2023 21:07
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 26, 2023
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2023
@auto-submit auto-submit bot merged commit 0da6f04 into flutter:master May 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 2, 2023
flutter/flutter@ee162e4...3db9504

2023-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 340936f7c03c to a4d4ad9dae1a (1 revision) (flutter/flutter#127772)
2023-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57e491a46e05 to 340936f7c03c (1 revision) (flutter/flutter#127767)
2023-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from a37b1a38d97a to 57e491a46e05 (1 revision) (flutter/flutter#127765)
2023-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1698020bd57 to a37b1a38d97a (1 revision) (flutter/flutter#127761)
2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e97c7379c7f to b1698020bd57 (1 revision) (flutter/flutter#127758)
2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0f38a0f0a18a to 9e97c7379c7f (1 revision) (flutter/flutter#127755)
2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1187168472a7 to 0f38a0f0a18a (1 revision) (flutter/flutter#127752)
2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3426cb827efb to 1187168472a7 (1 revision) (flutter/flutter#127745)
2023-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 795db50e7453 to 3426cb827efb (9 revisions) (flutter/flutter#127738)
2023-05-27 tessertaha@gmail.com Updated the `ToggleButtons` API doc to link to `SegmentedButton` (flutter/flutter#127021)
2023-05-26 nbosch@google.com Remove more `test_api/src` imports (flutter/flutter#127716)
2023-05-26 31859944+LongCatIsLooong@users.noreply.github.com Move shared inline widget logic to `RenderInlineWidgetContainerDefaults` (flutter/flutter#127308)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b5b5fc96b8f to 795db50e7453 (1 revision) (flutter/flutter#127720)
2023-05-26 pq@users.noreply.github.com Update collection-fors to prefer final (as per updated `prefer_final_in_for_each`) (flutter/flutter#127511)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from eed12f36f595 to 3b5b5fc96b8f (1 revision) (flutter/flutter#127713)
2023-05-26 gspencergoog@users.noreply.github.com Remove references to deprecated `ThemeData.primaryColorBrightness` (flutter/flutter#127238)
2023-05-26 katelovett@google.com TwoDimensional scrolling foundation (flutter/flutter#125437)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 858d9753453c to eed12f36f595 (2 revisions) (flutter/flutter#127702)
2023-05-26 36861262+QuncCccccc@users.noreply.github.com Remove button announcement for `MenuItemButton` and `SubmenuButton` (flutter/flutter#127620)
2023-05-26 chillers@google.com Reland "Update labeler action wildcards #127524" (flutter/flutter#127690)
2023-05-26 vashworth@google.com Revert "Log all lines from ios-deploy (#127502)" (flutter/flutter#127684)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ec7b0ae3599f to 858d9753453c (2 revisions) (flutter/flutter#127700)
2023-05-26 tessertaha@gmail.com Add M3 date range picker tests and fix header background theme color (flutter/flutter#127662)
2023-05-26 reidbaker@google.com Support minifcation for apps that depend on AGP 8 and integration_test (flutter/flutter#127628)
2023-05-26 gspencergoog@users.noreply.github.com Bump Snippet version (flutter/flutter#127688)
2023-05-26 chris@bracken.jp [Linux] Use up_client_get_devices2 when possible (flutter/flutter#127699)
2023-05-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 84f2fc16e55d to ec7b0ae3599f (3 revisions) (flutter/flutter#127698)
2023-05-26 5236035+fzyzcjy@users.noreply.github.com Fix `TextField` error in production environment because it wrongly uses ancestor render boxes (flutter/flutter#126324)
2023-05-26 127535196+JsGjKJzi@users.noreply.github.com Interactive viewer doesn't appear to respect the trackpadScrollCausesScale parameter (flutter/flutter#127114)
2023-05-26 chillers@google.com Remove release timeline (flutter/flutter#127685)
2023-05-26 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 8573f3b63a1f to 84f2fc16e55d (7 revisions) (flutter/flutter#127676)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants