Skip to content

Conversation

pq
Copy link
Contributor

@pq pq commented May 24, 2023

(This will need to be manually added to the roll that brings in https://dart-review.googlesource.com/c/sdk/+/304360)

/cc @aam

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 24, 2023
@github-actions github-actions bot removed the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 24, 2023
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 24, 2023
@pq pq marked this pull request as draft May 24, 2023 17:32
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

bdero added a commit that referenced this pull request May 24, 2023
Rolls engine to head with
[fixes](#127505) corresponding to
the [latest Dart roll](flutter/engine#42286).
@pq pq closed this Aug 1, 2023
@pq pq deleted the expectedMainErrors_fix branch August 1, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant