Skip to content

[Windows] Address feedback for show window comment #127998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

[Windows] Address feedback for show window comment #127998

merged 1 commit into from
May 31, 2023

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented May 31, 2023 •
edited
Loading

Address Tong's feedback here: #127695 (comment)

Follow-up to: #127046

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
@github-actions github-actions bot removed tool Affects the "flutter" command-line tool. See also t: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 31, 2023
@loic-sharma loic-sharma marked this pull request as ready for review May 31, 2023 23:13
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
dkwingsmt
dkwingsmt approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (how does this comment change affect so much!)

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2023
@auto-submit auto-submit bot merged commit 071ea49 into flutter:master May 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
071ea49 [Windows] Address feedback for show window comment (flutter/f…
a527569 
…lutter#127998)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
071ea49 [Windows] Address feedback for show window comment (flutter/f…
3bc11a4 
…lutter#127998)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
071ea49 [Windows] Address feedback for show window comment (flutter/f…
e241f75 
…lutter#127998)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
071ea49 [Windows] Address feedback for show window comment (flutter/f…
0857d18 
…lutter#127998)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
071ea49 [Windows] Address feedback for show window comment (flutter/f…
6d50d4c 
…lutter#127998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@cbracken cbracken Awaiting requested review from cbracken

@yaakovschectman yaakovschectman Awaiting requested review from yaakovschectman

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic-sharma @dkwingsmt