Skip to content

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Aug 9, 2023

Fixes #132274.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Aug 9, 2023
@goderbauer goderbauer changed the title WIP - check code analyzer Analyze snippets in flutter_test docs Aug 9, 2023
@goderbauer goderbauer marked this pull request as ready for review August 9, 2023 23:41
@goderbauer goderbauer requested a review from gspencergoog August 9, 2023 23:42
@goderbauer goderbauer changed the title Analyze snippets in flutter_test docs Analyze code snippets in flutter_test docs Aug 9, 2023
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@@ -57,6 +57,9 @@ class Evaluation {
}
}

// Examples can assume:
// typedef HomePage = Placeholder;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we can do aliasing typedefs now? Like actual typedefs? That's cool!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@auto-submit auto-submit bot merged commit 64a0683 into flutter:master Aug 10, 2023
@goderbauer goderbauer deleted the tryErrorInDart branch August 10, 2023 17:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippets in flutter_test docs are not analyzed and contain errors
3 participants