Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShortcutManager should dispatch creation in constructor. #133487

Merged
merged 11 commits into from Aug 29, 2023
Merged

ShortcutManager should dispatch creation in constructor. #133487

merged 11 commits into from Aug 29, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Aug 28, 2023 •
edited

First attempt was reverted: #133356

Fixes: #133515

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 28, 2023
@polina-c polina-c marked this pull request as draft August 28, 2023 19:29
@vashworth
Copy link
Contributor

@polina-c Looks like this PR is still a draft? Is it ready to review? Also, since you've changed the logic a bit and it's not a straight revert, can you request @chunhtai review once it's ready?

chunhtai
chunhtai reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not fixing the leak in this pr, may be good to add a todo at the line that supposed to dispose the manager to remind us that the migration has not completed

@polina-c
Copy link
Contributor Author

It is draft, because I want to know which tests will fail in order to disable them and add TODO.

@polina-c polina-c mentioned this pull request Aug 28, 2023
Closed
@github-actions github-actions bot added the f: gestures flutter/packages/flutter/gestures repository. label Aug 28, 2023
@polina-c polina-c marked this pull request as ready for review August 28, 2023 23:03
@polina-c polina-c requested a review from chunhtai August 28, 2023 23:06
@polina-c
Copy link
Contributor Author

polina-c commented Aug 28, 2023 •
edited

There are too many failures. Will try to submit fix. Maybe this time it will stay.
I little worry that the disposal is for public field.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. labels Aug 28, 2023
chunhtai
chunhtai approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit ae64abc into master Aug 29, 2023
76 checks passed
@polina-c polina-c deleted the revert-133472-revert-133356-ShortcutManager branch August 29, 2023 17:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2023
@engine-flutter-autoroll
ae64abc61 ShortcutManager should dispatch creation in constructor. (f…
1d50d21 
…lutter/flutter#133487)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 30, 2023
@engine-flutter-autoroll
Roll Flutter from 6c95737375db to 1fe24956ac46 (24 revisions) (#4817)
5ad43c8 
flutter/flutter@6c95737...1fe2495

2023-08-30 leroux_bruno@yahoo.fr Update SelectableRegion test for M3 (flutter/flutter#129627)
2023-08-30 godofredoc@google.com Remove cirrus tests from the flutter framework. (flutter/flutter#133575)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 749e67a947bc to 69f04bdfe952 (2 revisions) (flutter/flutter#133621)
2023-08-30 xilaizhang@google.com [flutter roll] Revert "Fix `Chip.shape`'s side is not used when provided in Material 3" (flutter/flutter#133615)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9f2cf5c99b0f to 749e67a947bc (2 revisions) (flutter/flutter#133618)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5854a6b3658 to 9f2cf5c99b0f (4 revisions) (flutter/flutter#133616)
2023-08-30 parlough@gmail.com No longer include `.packages` in created `.gitignore` files (flutter/flutter#133484)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from db3ecf8b2739 to c5854a6b3658 (1 revision) (flutter/flutter#133610)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1feb9302050c to db3ecf8b2739 (4 revisions) (flutter/flutter#133609)
2023-08-29 polinach@google.com Fix one notDisposed leak and mark another. (flutter/flutter#133595)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 01a1579808b5 to 1feb9302050c (1 revision) (flutter/flutter#133604)
2023-08-29 polinach@google.com Upgrade packages. (flutter/flutter#133593)
2023-08-29 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#133596)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73cc3fb451fd to 01a1579808b5 (3 revisions) (flutter/flutter#133591)
2023-08-29 hans.muller@gmail.com Added DropdownMenuEntry.labelWidget (flutter/flutter#133491)
2023-08-29 ian@hixie.ch Use a fake stopwatch to remove flakiness. (flutter/flutter#133229)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1e6eb080f08 to 73cc3fb451fd (3 revisions) (flutter/flutter#133580)
2023-08-29 mdebbar@google.com [web] Migrate remaining web-only API usages to `dart:ui_web` (flutter/flutter#132248)
2023-08-29 gspencergoog@users.noreply.github.com Add doxygen doc generation. (flutter/flutter#131356)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 50bd80773287 to d1e6eb080f08 (2 revisions) (flutter/flutter#133570)
2023-08-29 polinach@google.com ShortcutManager should dispatch creation in constructor. (flutter/flutter#133487)
2023-08-29 tessertaha@gmail.com Add FAB Additional Color Mappings example (flutter/flutter#133453)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 65438c7bb46a to 50bd80773287 (1 revision) (flutter/flutter#133565)
2023-08-29 engine-flutter-autoroll@skia.org Roll Packages from 383bffa to d7d3150 (13 revisions) (flutter/flutter#133564)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 1, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ae64abc61 ShortcutManager should dispatch creation in constructor. (f…
bd2965e 
…lutter/flutter#133487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@vashworth vashworth Awaiting requested review from vashworth

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_ShortcutRegistrarState initializes but not dispose the field manager
3 participants
@polina-c @vashworth @chunhtai