Cover last test/material tests with leak tracking. #137004

ksokolovskyi · 2023-10-21T09:31:56Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/material tests according to the dart-lang/leak_tracker#134.

Tests

Updates material/input_date_picker_form_field_test.dart to use testWidgetsWithLeakTracking;
Updates material/search_test.dart to use testWidgetsWithLeakTracking;
Updates material/search_view_theme_test.dart to use testWidgetsWithLeakTracking;
Updates material/time_picker_theme_test.dart to use testWidgetsWithLeakTracking;
Updates material/tooltip_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-10-21T12:13:50Z

cc @polina-c

ksokolovskyi · 2023-10-24T10:41:52Z

@polina-c thanks a lot for the review!

…lutter#137004)

Roll Flutter from 5e8b5f4 to 5dd2a4e (59 revisions) flutter/flutter@5e8b5f4...5dd2a4e 2023-10-25 15619084+vashworth@users.noreply.github.com Ensure Xcode project is setup to start debugger (flutter/flutter#136977) 2023-10-25 fluttergithubbot@gmail.com Marks Windows build_tests_6_6 to be unflaky (flutter/flutter#137216) 2023-10-25 godofredoc@google.com Remove gem and docker files. (flutter/flutter#137200) 2023-10-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#137264) 2023-10-25 jonahwilliams@google.com [gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#137199) 2023-10-25 engine-flutter-autoroll@skia.org Roll Packages from 2faf992 to f751ffb (11 revisions) (flutter/flutter#137254) 2023-10-25 fluttergithubbot@gmail.com Marks Windows build_tests_3_6 to be unflaky (flutter/flutter#137214) 2023-10-25 fluttergithubbot@gmail.com Marks Windows build_tests_5_6 to be unflaky (flutter/flutter#137215) 2023-10-25 fluttergithubbot@gmail.com Marks Windows build_tests_2_6 to be unflaky (flutter/flutter#137213) 2023-10-25 tessertaha@gmail.com Revert "Update `OutlinedButton` tests for Material 3 (#136809)" (flutter/flutter#137242) 2023-10-25 tessertaha@gmail.com Update `OutlinedButton` tests for Material 3 (flutter/flutter#136809) 2023-10-25 5236035+fzyzcjy@users.noreply.github.com Let `OverflowBox` be shrink-wrappable (flutter/flutter#129095) 2023-10-25 polinach@google.com Add dependency on leak_tracker to flutter_test. (flutter/flutter#137069) 2023-10-25 ybz975218925@gmail.com fix SliverReorderableLists item wrong offset (flutter/flutter#136828) 2023-10-25 jacksongardner@google.com Remove `bringup: true` from realm_checker and remove the redundant tool test. (flutter/flutter#137186) 2023-10-25 36861262+QuncCccccc@users.noreply.github.com Revert "Fix Gradle lockfiles." (flutter/flutter#137198) 2023-10-24 polinach@google.com Fix Gradle lockfiles. (flutter/flutter#137190) 2023-10-24 pateltirth454@gmail.com Fix Typos (flutter/flutter#137173) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6a48e9963df to 6e09ee14e244 (1 revision) (flutter/flutter#137185) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 602b5131ee4d to d6a48e9963df (6 revisions) (flutter/flutter#137180) 2023-10-24 42715466+lirantzairi@users.noreply.github.com TextField - allow to customize cursor color in error state (flutter/flutter#136121) 2023-10-24 chris@bracken.jp [macOS] Refactor macOS build/codesize analysis (flutter/flutter#137164) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from dc00de7dacf4 to 602b5131ee4d (1 revision) (flutter/flutter#137174) 2023-10-24 jacksongardner@google.com Check the realm file in its own shard. (flutter/flutter#137160) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1890bd7dc412 to dc00de7dacf4 (1 revision) (flutter/flutter#137172) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca7ef01c99c6 to 1890bd7dc412 (2 revisions) (flutter/flutter#137158) 2023-10-24 godofredoc@google.com Migrate mac builds to ruby dep. (flutter/flutter#136929) 2023-10-24 engine-flutter-autoroll@skia.org Roll Packages from 4bf5114 to 2faf992 (7 revisions) (flutter/flutter#137154) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7224835bb65f to ca7ef01c99c6 (1 revision) (flutter/flutter#137153) 2023-10-24 imcusg@gmail.com fix some typos (flutter/flutter#137144) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f7488e0b4b5 to 7224835bb65f (1 revision) (flutter/flutter#137150) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d58895093d0a to 8f7488e0b4b5 (3 revisions) (flutter/flutter#137135) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a8471f188cd to d58895093d0a (4 revisions) (flutter/flutter#137130) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 71600d89aa3f to 2a8471f188cd (2 revisions) (flutter/flutter#137129) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3dd197dcf9e5 to 71600d89aa3f (1 revision) (flutter/flutter#137127) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from bdbd1058858b to 3dd197dcf9e5 (2 revisions) (flutter/flutter#137125) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ef5caa91c40 to bdbd1058858b (1 revision) (flutter/flutter#137119) 2023-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use `coverage.collect`'s `coverableLineCache` param to speed up coverage" (flutter/flutter#137121) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd6a6531e816 to 0ef5caa91c40 (1 revision) (flutter/flutter#137114) 2023-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0bd703132cc1 to dd6a6531e816 (2 revisions) (flutter/flutter#137111) 2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from abeab897a29c to 0bd703132cc1 (3 revisions) (flutter/flutter#137107) 2023-10-23 polinach@google.com Upgrade packages in flutter and flutter_test. (flutter/flutter#137106) 2023-10-23 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.1 (flutter/flutter#137103) 2023-10-23 goderbauer@google.com Dartdoc warnings (flutter/flutter#137077) 2023-10-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from e89f0421bcab to abeab897a29c (5 revisions) (flutter/flutter#137100) 2023-10-23 sokolovskyi.konstantin@gmail.com Cover last test/material tests with leak tracking. (flutter/flutter#137004) ...

Cover last material tests

95c86aa

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 21, 2023

ksokolovskyi mentioned this pull request Oct 21, 2023

Clean up notDisposed leaks in Flutter Framework, phase 1. dart-lang/leak_tracker#134

Closed

ksokolovskyi added 2 commits October 23, 2023 22:13

Merge branch 'master' into leak-tracking-tests-14

7d76cfb

Cover latest tests

21d7979

polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 23, 2023

polina-c approved these changes Oct 23, 2023

View reviewed changes

polina-c merged commit 38f318b into flutter:master Oct 23, 2023
61 checks passed

engine-flutter-autoroll mentioned this pull request Oct 24, 2023

Roll Flutter from 5e8b5f4ea293 to 4dd48905bb92 (29 revisions) flutter/packages#5212

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

51eaa6f

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 24, 2023

Roll Flutter from 5e8b5f4ea293 to 664915f38b1f (31 revisions) flutter/packages#5213

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

bc297c9

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 24, 2023

Roll Flutter from 5e8b5f4ea293 to 88643f90d930 (32 revisions) flutter/packages#5216

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

f20babd

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 25, 2023

Roll Flutter from 5e8b5f4ea293 to cd2c08ee510e (53 revisions) flutter/packages#5228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

c44d17b

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 25, 2023

Roll Flutter from 5e8b5f4ea293 to de93f0268a0c (54 revisions) flutter/packages#5229

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

afdd360

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 25, 2023

Roll Flutter from 5e8b5f4ea293 to aaf7184a4262 (55 revisions) flutter/packages#5230

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

61ebde7

…lutter#137004)

engine-flutter-autoroll mentioned this pull request Oct 25, 2023

Roll Flutter from 5e8b5f4ea293 to 5dd2a4e0aaef (59 revisions) flutter/packages#5231

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023

38f318b Cover last test/material tests with leak tracking. (flutter/f…

bc693fc

…lutter#137004)

HansMuller mentioned this pull request Nov 1, 2023

Flutter Framework Team: Notable Commits #121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cover last test/material tests with leak tracking. #137004

Cover last test/material tests with leak tracking. #137004

ksokolovskyi commented Oct 21, 2023 •

edited

Loading

ksokolovskyi commented Oct 21, 2023

ksokolovskyi commented Oct 24, 2023

Cover last test/material tests with leak tracking. #137004

Cover last test/material tests with leak tracking. #137004

Conversation

ksokolovskyi commented Oct 21, 2023 • edited Loading

Description

Tests

Pre-launch Checklist

ksokolovskyi commented Oct 21, 2023

ksokolovskyi commented Oct 24, 2023

ksokolovskyi commented Oct 21, 2023 •

edited

Loading