Skip to content

fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) #170206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

nakanoh
Copy link
Contributor

@nakanoh nakanoh commented Jun 8, 2025

This PR fixes a typo in the comment of analysis_options.yaml, changing 'disabeling' to 'disabling'. This is a simple typo fix in a comment that improves code readability.

No issue is required as this is a trivial typo fix in a comment.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Jun 8, 2025
@Ander94-nubbi

This comment was marked as off-topic.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@Piinks Piinks removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@Piinks
Copy link
Contributor

Piinks commented Jul 7, 2025

Removed autosubmit as we are about to close the tree to bump Dart.

@Piinks
Copy link
Contributor

Piinks commented Jul 8, 2025

Restoring autosubmit label now that the tree is open again.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
Copy link
Contributor

auto-submit bot commented Jul 21, 2025

autosubmit label was removed for flutter/flutter/170206, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tirth-patel-nc tirth-patel-nc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 22, 2025
Merged via the queue into flutter:master with commit 404fb3f Jul 22, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 22, 2025
flutter/flutter@70cdc0c...ee0cc66

2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…abling) (flutter#170206)

This PR fixes a typo in the comment of `analysis_options.yaml`, changing
'disabeling' to 'disabling'. This is a simple typo fix in a comment that
improves code readability.

No issue is required as this is a trivial typo fix in a comment.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9662)

flutter/flutter@70cdc0c...ee0cc66

2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…abling) (flutter#170206)

This PR fixes a typo in the comment of `analysis_options.yaml`, changing
'disabeling' to 'disabling'. This is a simple typo fix in a comment that
improves code readability.

No issue is required as this is a trivial typo fix in a comment.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants