Skip to content

Re-pin package:intl #171438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Re-pin package:intl #171438

merged 1 commit into from
Jul 1, 2025

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jul 1, 2025 •
edited
Loading

Reverts #169286.

I am in agreement with the goal of unpinning packages dependencies, but a change of this significance should have a fleshed out design doc and plan, and be presented at the Dash forum so that the whole team is aware of the changes.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Jul 1, 2025
@mosuem
Copy link
Contributor

mosuem commented Jul 1, 2025

I don't see why this needs to be reverted, could you elaborate here or on one of the discussion channels linked in #169286 (comment)? Thanks!

@zanderso
Copy link
Member Author

zanderso commented Jul 1, 2025

Yeah, as I explained in the original PR: "I don't believe it should have been approved without a more fleshed out plan, design review, and communication of the change and plan to the whole team. Since the branch cut for the next stable is only days away, we will have to revert this change in order to proceed with it in a way that agrees with our team's norms."

@zanderso zanderso requested review from jtmcdole and Piinks July 1, 2025 14:18
Piinks
Piinks approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 1, 2025
Merged via the queue into flutter:master with commit 253cae1 Jul 1, 2025
70 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@zanderso zanderso deleted the revert-package-unpin branch July 1, 2025 15:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
f49a646
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
bfe23b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
f8bc042
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
28d7734
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
bf0938e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
f2fe911
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
623bfb3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
c44a20e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
32b37e1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
57502a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
90c7d48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
092628a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
0d1dcd5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
bbe7f67
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
a885b97
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
e6ba182
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
5487df7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
8474e90
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
f5809b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
702a234
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
4acee7f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
ebd9d46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
53bb4b2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
75d80e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
8d27a25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
5e4ec0c
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@zanderso @mboetger
Re-pin package:intl (flutter#171438)
49fbc81 
Reverts flutter#169286.

I am in agreement with the goal of unpinning packages dependencies, but
a change of this significance should have a fleshed out design doc and
plan, and be presented at the Dash forum so that the whole team is aware
of the changes.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
01793d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
e37e62c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
fac403c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
de84b40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
253cae121 Re-pin package:intl (flutter/flutter#171438)
e11ae29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

@mosuem mosuem Awaiting requested review from mosuem

@justinmc justinmc Awaiting requested review from justinmc

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanderso @mosuem @Piinks