replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart` #174841

AbdeMohlbi · 2025-09-02T17:33:13Z

replace the usage of onPop with onPopWithResult to solve the analyzerr warning

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

justinmc

LGTM 👍

Thank you for fixing this! I also fixed a similar usage of onPop recently. I'm happy to review any more if you find any.

auto-submit · 2025-09-23T15:23:36Z

autosubmit label was removed for flutter/flutter/174841, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

justinmc

Google testing seems to have failed for an unrelated reason. If you push another commit I think it will re-run.

justinmc · 2025-09-23T15:45:41Z

examples/api/lib/material/navigation_bar/navigation_bar.2.dart

  Widget build(BuildContext context) {
    return NavigatorPopHandler(
-      onPop: () {
+      onPopWithResult: (_) {


Actually, could you replace the underscore here with the actual type and name? See https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#avoid-anonymous-parameter-names

i used Object? result is it correct ?

I would do (void result). The type is the type parameter given to NavigatorPopHandler, and you don't have one because you have no result.

flutter/packages/flutter/lib/src/widgets/navigator_pop_handler.dart

Line 139 in fbe5627

typedef PopResultCallback<T> = void Function(T? result);

it's void result now , thank u

justinmc

LGTM 👍

…_bar.2.dart ` (flutter/flutter#174841)

…10160) Manual roll requested by tarrinneal@google.com flutter/flutter@c9608e2...7811e89 2025-10-01 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateTextStyle` (flutter/flutter#176330) 2025-10-01 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateOutlinedBorder` (flutter/flutter#176270) 2025-10-01 matej.knopp@gmail.com [win32] Runloop should use high resolution timer and avoid deadlock (flutter/flutter#176023) 2025-10-01 engine-flutter-autoroll@skia.org Roll Packages from 287739d to 321a584 (3 revisions) (flutter/flutter#176357) 2025-10-01 15619084+vashworth@users.noreply.github.com Add SwiftUI support for UIScene migration (flutter/flutter#176230) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from ecaff95f51aa to c44a36470d07 (4 revisions) (flutter/flutter#176336) 2025-10-01 dacoharkes@google.com [native assets] Enable build hooks and code assets on stable (flutter/flutter#176285) 2025-10-01 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#176287) 2025-10-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 527333cfe4cf to 8ffec1435cf3 (1 revision) (flutter/flutter#176334) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from 6998b06397c5 to ecaff95f51aa (1 revision) (flutter/flutter#176333) 2025-10-01 Krzysztof.swietnicki@gmail.com Update description in _LastFinderMixin to properly describe finding last (flutter/flutter#174232) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from b242cc09488d to 6998b06397c5 (2 revisions) (flutter/flutter#176331) 2025-10-01 engine-flutter-autoroll@skia.org Roll Dart SDK from af31d2637b6b to 527333cfe4cf (17 revisions) (flutter/flutter#176325) 2025-10-01 scheglov@google.com Stop using deprecated analyzer 7.x.y APIs. (flutter/flutter#176242) 2025-10-01 victorsanniay@gmail.com Fix docs referencing deprecated radio properties (flutter/flutter#176244) 2025-09-30 engine-flutter-autoroll@skia.org Roll Skia from bb3b6bd4be0d to b242cc09488d (22 revisions) (flutter/flutter#176320) 2025-09-30 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rcOl0yxJb4znJ903Y... to 1Ai6VL4vb_GdGnWhg... (flutter/flutter#176315) 2025-09-30 47866232+chunhtai@users.noreply.github.com Adds dart ui API for setting application level locale (flutter/flutter#175100) 2025-09-30 mohellebiabdessalem@gmail.com replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart ` (flutter/flutter#174841) 2025-09-30 bkonyi@google.com [ Widget Preview ] Forward Widget Inspector navigation events via DTD (flutter/flutter#176218) 2025-09-30 15619084+vashworth@users.noreply.github.com Add verbose logs to module_uiscene_test_ios (flutter/flutter#176306) 2025-09-30 zhongliu88889@gmail.com Web semantics: Fix email field selection/cursor by using type="text" + inputmode="email" (flutter/flutter#175876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…t ` (flutter#174841) replace the usage of `onPop ` with `onPopWithResult ` to solve the analyzerr warning ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Update navigation_bar.2.dart

7f5d39f

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Sep 2, 2025

AbdeMohlbi changed the title ~~Update navigation_bar.2.dart~~ replace onPop usage with onPopWithResult in navigation_bar.2.dart Sep 2, 2025

AbdeMohlbi changed the title ~~replace onPop usage with onPopWithResult in navigation_bar.2.dart~~ replace onPop usage with onPopWithResult in navigation_bar.2.dart Sep 2, 2025

AbdeMohlbi marked this pull request as ready for review September 2, 2025 18:05

AbdeMohlbi added 2 commits September 21, 2025 20:50

Merge branch 'master' into patch-34

0b3a9a8

Merge branch 'master' into patch-34

73d4959

AbdeMohlbi requested a review from justinmc September 22, 2025 20:22

justinmc approved these changes Sep 22, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

Merge branch 'master' into patch-34

ffc025c

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

justinmc reviewed Sep 23, 2025

View reviewed changes

use `Object? result'

e09d745

AbdeMohlbi requested a review from justinmc September 23, 2025 16:22

AbdeMohlbi added 2 commits September 30, 2025 15:50

Merge branch 'master' into patch-34

bf13993

Update navigation_bar.2.dart

4e86941

justinmc approved these changes Sep 30, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2025

auto-submit bot added this pull request to the merge queue Sep 30, 2025

Merged via the queue into flutter:master with commit a2c1b38 Oct 1, 2025
45 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 72eec03e860a (43 revisions) flutter/packages#10156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

a2c1b383c replace onPop usage with onPopWithResult in `navigation…

fbd3866

…_bar.2.dart ` (flutter/flutter#174841)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 80496d7662ac (44 revisions) flutter/packages#10157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

a2c1b383c replace onPop usage with onPopWithResult in `navigation…

f538e2c

…_bar.2.dart ` (flutter/flutter#174841)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 7519cfd2515c (45 revisions) flutter/packages#10158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

a2c1b383c replace onPop usage with onPopWithResult in `navigation…

763a466

…_bar.2.dart ` (flutter/flutter#174841)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

a2c1b383c replace onPop usage with onPopWithResult in `navigation…

1d272d1

…_bar.2.dart ` (flutter/flutter#174841)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from c9608e28d01a to 77a581a19e06 (20 revisions) flutter/packages#10159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

a2c1b383c replace onPop usage with onPopWithResult in `navigation…

f6be3b1

…_bar.2.dart ` (flutter/flutter#174841)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Manual roll Flutter from c9608e28d01a to 7811e8982355 (22 revisions) flutter/packages#10160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart` #174841

replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart` #174841

AbdeMohlbi commented Sep 2, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

This comment was marked as resolved.

auto-submit bot commented Sep 23, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc Sep 23, 2025

Uh oh!

AbdeMohlbi Sep 23, 2025

Uh oh!

justinmc Sep 30, 2025

Uh oh!

AbdeMohlbi Sep 30, 2025

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Uh oh!

replace onPop usage with onPopWithResult in navigation_bar.2.dart #174841

replace onPop usage with onPopWithResult in navigation_bar.2.dart #174841

Conversation

AbdeMohlbi commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

auto-submit bot commented Sep 23, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart` #174841

replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart` #174841

AbdeMohlbi commented Sep 2, 2025 •

edited

Loading