Skip to content

Conversation

ash2moon
Copy link
Contributor

@ash2moon ash2moon commented Sep 17, 2025

Bumps robolectric to support Android API 36 and JDK to 21
One of the tests is failing due to a change in how JDK 19 handles unicode characters in word breaks. The test was skipped and a new issue was created below.
#175623

Resolves #175454
Unblocks #174981

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Sep 17, 2025
@ash2moon ash2moon marked this pull request as ready for review September 19, 2025 17:01
@ash2moon ash2moon requested a review from a team as a code owner September 19, 2025 17:01
Copy link
Contributor

@jesswrd jesswrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update engine/src/flutter/shell/platform/android/test_runner/src/main/resources/robolectric.properties to sdk=36? Thanks

@ash2moon
Copy link
Contributor Author

Can you also update engine/src/flutter/shell/platform/android/test_runner/src/main/resources/robolectric.properties to sdk=36? Thanks

Good catch!

@jesswrd jesswrd self-requested a review September 22, 2025 17:53
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Sep 22, 2025
Merged via the queue into flutter:master with commit d5592e4 Sep 22, 2025
189 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 23, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 24, 2025
…10067)

Manual roll requested by bmparr@google.com

flutter/flutter@9ff2767...4a04204

2025-09-23 mohellebiabdessalem@gmail.com Simplify asserts in `FlutterMutatorTest` (flutter/flutter#175730)
2025-09-23 mohellebiabdessalem@gmail.com Improve code quality in `AccessibilityBridgeTest.java` (flutter/flutter#175718)
2025-09-23 mohellebiabdessalem@gmail.com Fix linter issues in `VsyncWaiterTest` Capital L for long values (flutter/flutter#175780)
2025-09-23 mohellebiabdessalem@gmail.com Fix wrong order of asserts arguments (flutter/flutter#175726)
2025-09-23 mohellebiabdessalem@gmail.com Simplify test asserts and use lambdas  (flutter/flutter#175727)
2025-09-23 mohellebiabdessalem@gmail.com Remove unused imports, fix assertion order, add non null annotations to `ImageReaderPlatformViewRenderTargetTest.java` (flutter/flutter#175723)
2025-09-23 mohellebiabdessalem@gmail.com Remove unnecessary `String.valueOf` in `KeyboardManager.java` (flutter/flutter#175502)
2025-09-23 mohellebiabdessalem@gmail.com Fix outdated link of `intl` package to point to the correct new location  (flutter/flutter#174498)
2025-09-23 engine-flutter-autoroll@skia.org Roll Packages from 45c9a84 to 3413b65 (4 revisions) (flutter/flutter#175854)
2025-09-23 mohellebiabdessalem@gmail.com Fix typo in tests `README` (flutter/flutter#175788)
2025-09-23 byoungchan.lee@gmx.com Update maximum known Gradle version to 9.1.0 (flutter/flutter#175543)
2025-09-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 9e943fe076c8 to 14b4ced3022a (5 revisions) (flutter/flutter#175843)
2025-09-23 bruno.leroux@gmail.com Document how to hide counter in TextField.maxLength (flutter/flutter#175797)
2025-09-23 bruno.leroux@gmail.com [a11y-app] Fix Autocomplete semantics label (flutter/flutter#175409)
2025-09-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CcCe3HpQtBYhTZscb... to naeytagBIBEpKgZNZ... (flutter/flutter#175824)
2025-09-23 engine-flutter-autoroll@skia.org Roll Skia from a38a531dec1d to cabeab8cb22c (16 revisions) (flutter/flutter#175822)
2025-09-23 jiahaog@users.noreply.github.com Load fonts in the order addFont is called (flutter/flutter#174253)
2025-09-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#175545)
2025-09-22 mohellebiabdessalem@gmail.com Remove `name` field form `SupportedPlatform` enum (flutter/flutter#175611)
2025-09-22 mdebbar@google.com [web] Cleanup opportunities post renderer unification (flutter/flutter#174659)
2025-09-22 mohellebiabdessalem@gmail.com Update `KeyChannelResponder.java`  to use method reference  (flutter/flutter#175510)
2025-09-22 dominik@roszkowski.dev Update docs/engine/contributing/Compiling-the-engine.md with macOS build steps (flutter/flutter#175716)
2025-09-22 bkonyi@google.com [ Widget Preview ] Allow for custom `Preview` annotations, add support for runtime transformations (flutter/flutter#175535)
2025-09-22 mohellebiabdessalem@gmail.com Remove unnecessary public modifier in `KeyboardManager.java` (flutter/flutter#175500)
2025-09-22 muhatashim@google.com bump robolectric and java to 21 (flutter/flutter#175550)
2025-09-22 dixita0607@users.noreply.github.com Fix: Update docs tool tag to sample in ImageProvider (flutter/flutter#175256)
2025-09-22 stuartmorgan@google.com  Roll Packages from 3d5c419 to 45c9a84 (flutter/flutter#175794)
2025-09-21 dkwingsmt@users.noreply.github.com Correctly implement PlatformViews' cursors on Web (flutter/flutter#174300)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
Bumps robolectric to support Android API 36 and JDK to 21
One of the tests is failing due to a change in how JDK 19 handles
unicode characters in word breaks. The test was skipped and a new issue
was created below.
flutter#175623

Resolves flutter#175454
Unblocks flutter#174981

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update robolectric tests to use Java 21

2 participants