Skip to content

Fix wrong order of asserts arguments #175726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
+38 −38
Merged

Fix wrong order of asserts arguments #175726

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23eb4a8
Update LocalizationPluginTest.java
AbdeMohlbi Sep 21, 2025
055b45a
Merge branch 'master' into AbdeMohlbi-patch-8
AbdeMohlbi Sep 22, 2025
c557e02
Merge branch 'master' into AbdeMohlbi-patch-8
AbdeMohlbi Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions ...er/shell/platform/android/test/io/flutter/plugin/localization/LocalizationPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void computePlatformResolvedLocaleAPI26() {
// Empty supportedLocales.
String[] supportedLocales = new String[] {};
String[] result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
assertEquals(result.length, 0);
assertEquals(0, result.length);

// Empty preferredLocales.
supportedLocales =
Expand All @@ -70,10 +70,10 @@ public void computePlatformResolvedLocaleAPI26() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The first locale is default.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "FR");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("FR", result[1]);
assertEquals("", result[2]);

// Example from https://developer.android.com/guide/topics/resources/multilingual-support#postN
supportedLocales =
Expand All @@ -88,10 +88,10 @@ public void computePlatformResolvedLocaleAPI26() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "FR");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("FR", result[1]);
assertEquals("", result[2]);

supportedLocales =
new String[] {
Expand All @@ -107,10 +107,10 @@ public void computePlatformResolvedLocaleAPI26() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("", result[1]);
assertEquals("", result[2]);

// Example from https://developer.android.com/guide/topics/resources/multilingual-support#postN
supportedLocales =
Expand All @@ -127,10 +127,10 @@ public void computePlatformResolvedLocaleAPI26() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "it");
assertEquals(result[1], "IT");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("it", result[0]);
assertEquals("IT", result[1]);
assertEquals("", result[2]);

supportedLocales =
new String[] {
Expand All @@ -140,10 +140,10 @@ public void computePlatformResolvedLocaleAPI26() {
localeList = new LocaleList(new Locale.Builder().setLanguage("zh").setRegion("CN").build());
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
assertEquals(result.length, 3);
assertEquals(result[0], "zh");
assertEquals(result[1], "CN");
assertEquals(result[2], "Hans");
assertEquals(3, result.length);
assertEquals("zh", result[0]);
assertEquals("CN", result[1]);
assertEquals("Hans", result[2]);
}

// This test should be synced with the version for API 26.
Expand Down Expand Up @@ -172,7 +172,7 @@ public void computePlatformResolvedLocale_fromAndroidN() {
// Empty supportedLocales.
String[] supportedLocales = new String[] {};
String[] result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
assertEquals(result.length, 0);
assertEquals(0, result.length);

// Empty preferredLocales.
supportedLocales =
Expand All @@ -185,10 +185,10 @@ public void computePlatformResolvedLocale_fromAndroidN() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The first locale is default.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "FR");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("FR", result[1]);
assertEquals("", result[2]);

// Example from https://developer.android.com/guide/topics/resources/multilingual-support#postN
supportedLocales =
Expand All @@ -203,10 +203,10 @@ public void computePlatformResolvedLocale_fromAndroidN() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "FR");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("FR", result[1]);
assertEquals("", result[2]);

supportedLocales =
new String[] {
Expand All @@ -221,10 +221,10 @@ public void computePlatformResolvedLocale_fromAndroidN() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "fr");
assertEquals(result[1], "");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("fr", result[0]);
assertEquals("", result[1]);
assertEquals("", result[2]);

// Example from https://developer.android.com/guide/topics/resources/multilingual-support#postN
supportedLocales =
Expand All @@ -241,10 +241,10 @@ public void computePlatformResolvedLocale_fromAndroidN() {
when(config.getLocales()).thenReturn(localeList);
result = flutterJNI.computePlatformResolvedLocale(supportedLocales);
// The call will use the new (> API 24) algorithm.
assertEquals(result.length, 3);
assertEquals(result[0], "it");
assertEquals(result[1], "IT");
assertEquals(result[2], "");
assertEquals(3, result.length);
assertEquals("it", result[0]);
assertEquals("IT", result[1]);
assertEquals("", result[2]);
}

@Test
Expand Down
Loading