Skip to content

Revert "[Impeller] Optimize scale translate rectangle transforms" #176161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2025
Merged

Revert "[Impeller] Optimize scale translate rectangle transforms" #176161

merged 1 commit into from
Sep 28, 2025
+2 −161

Conversation

flar
Copy link
Contributor

@flar flar commented Sep 28, 2025

Reverts #176123

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Sep 28, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 28, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a prior change that introduced optimizations for scale-translate rectangle transforms in Impeller. The revert removes the matrix classification logic, the specialized TransformBoundsTranslateScale2D function, and associated benchmarks and unit tests. The call sites in TransformAndClipBounds and TransformBounds are reverted to their previous logic, removing the optimized path. The revert appears to be clean and complete, correctly removing all aspects of the feature introduced in the original pull request.

@flar flar added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Sep 28, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit bot added this pull request to the merge queue Sep 28, 2025
Merged via the queue into master with commit dc56bc2 Sep 28, 2025
194 of 195 checks passed
@auto-submit auto-submit bot deleted the revert-176123-impeller-optimize-scale-translate-rect-transforms branch September 28, 2025 14:25
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
e0932ed 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
cb71a09 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
ba88e7f 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
b579dd2 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
c3cd0cb 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
3dbd935 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
16f82d1 
…forms" (flutter/flutter#176161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
dc56bc26b Revert "[Impeller] Optimize scale translate rectangle trans…
3a40ec3 
…forms" (flutter/flutter#176161)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 29, 2025
@engine-flutter-autoroll
Roll Flutter from 6cc976ec26d3 to 96fe3b3df509 (32 revisions) (#10125)
0158ffb 
Roll Flutter from 6cc976ec26d3 to 96fe3b3df509 (32 revisions)

flutter/flutter@6cc976e...96fe3b3

2025-09-29 engine-flutter-autoroll@skia.org Roll Packages from 389c678 to 34eec78 (6 revisions) (flutter/flutter#176205)
2025-09-29 engine-flutter-autoroll@skia.org Roll Skia from 9b2b942d1eb1 to bb3b6bd4be0d (4 revisions) (flutter/flutter#176201)
2025-09-29 bkonyi@google.com [ Widget Preview ] Improve IDE integration support (flutter/flutter#176114)
2025-09-29 robert.ancell@canonical.com Fix name of driver file (flutter/flutter#176186)
2025-09-29 engine-flutter-autoroll@skia.org Roll Skia from beb673968802 to 9b2b942d1eb1 (3 revisions) (flutter/flutter#176190)
2025-09-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Z45OXT_Wb8aWI3a0... to 8zjcJic_DtvB2Bo2x... (flutter/flutter#176158)
2025-09-28 flar@google.com Revert "[Impeller] Optimize scale translate rectangle transforms" (flutter/flutter#176161)
2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from 2e5da5c0a9cd to beb673968802 (1 revision) (flutter/flutter#176145)
2025-09-27 flar@google.com [Impeller] Optimize scale translate rectangle transforms (flutter/flutter#176123)
2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from d8422aaf8f89 to 2e5da5c0a9cd (2 revisions) (flutter/flutter#176141)
2025-09-27 mdebbar@google.com [web] Remove mention of non-existent `canvaskit_lock.yaml` (flutter/flutter#176108)
2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from 96b73f61fe61 to d8422aaf8f89 (2 revisions) (flutter/flutter#176118)
2025-09-27 sokolovskyi.konstantin@gmail.com [a11y] Add `expanded` flag support to Android. (flutter/flutter#174981)
2025-09-26 ahmedsameha1@gmail.com Make sure that a DesktopTextSelectionToolbar doesn't crash in 0x0 env… (flutter/flutter#173928)
2025-09-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 899c7340cc4c to af31d2637b6b (11 revisions) (flutter/flutter#176056)
2025-09-26 1063596+reidbaker@users.noreply.github.com Update java version ranges with the top end limitation for java pre 17 (flutter/flutter#176049)
2025-09-26 1063596+reidbaker@users.noreply.github.com Add warn java evaluation to android_workflow (flutter/flutter#176097)
2025-09-26 katelovett@google.com Removes type annotations in templates (flutter/flutter#176106)
2025-09-26 fluttergithubbot@gmail.com Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#175917)
2025-09-26 1063596+reidbaker@users.noreply.github.com Add kotlin/kgp 2.2.* evaluation criteria.  (flutter/flutter#176094)
2025-09-26 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateMouseCursor` (flutter/flutter#175981)
2025-09-26 engine-flutter-autoroll@skia.org Roll Packages from 117bf63 to 389c678 (4 revisions) (flutter/flutter#176092)
2025-09-26 34871572+gmackall@users.noreply.github.com Fix link to .gclient setup instructions (flutter/flutter#176046)
2025-09-26 matt.kosarek@canonical.com Implement Regular Windows for the win32 framework + add an example application for regular windows (flutter/flutter#173715)
2025-09-26 engine-flutter-autoroll@skia.org Roll Skia from 5d99c3fc7c83 to 96b73f61fe61 (3 revisions) (flutter/flutter#176075)
2025-09-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from naeytagBIBEpKgZNZ... to 0Z45OXT_Wb8aWI3a0... (flutter/flutter#176068)
2025-09-26 100504385+AlsoShantanuBorkar@users.noreply.github.com Add itemClipBehavior property for CarouselView's children (flutter/flutter#175324)
2025-09-26 engine-flutter-autoroll@skia.org Roll Skia from 55436d87e414 to 5d99c3fc7c83 (4 revisions) (flutter/flutter#176060)
2025-09-26 flar@google.com Revert "[Impeller] Optimize scale translate rectangle transforms" (flutter/flutter#176061)
2025-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Update the AccessibilityPlugin::Announce method to account f… (#174365)" (flutter/flutter#176059)
2025-09-25 ahmedsameha1@gmail.com Make sure that a CupertinoDesktopTextSelectionToolbarButton doesn't c… (flutter/flutter#173894)
2025-09-25 mohellebiabdessalem@gmail.com Improve code quality in `SensitiveContentPluginTest.java` (flutter/flutter#175721)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flar @jason-simmons