-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[ Tool ] Roll package:dwds to 26.0.0 #176808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the dwds
package to version 26.0.0 to fix an issue with expression evaluation for scripts without a library URI. To support this, a scriptUri
parameter has been added to the web expression compilation flow. A significant and welcome improvement is the switch from a custom line-based protocol to JSON for communication with the frontend server when compiling expressions, which enhances robustness and extensibility.
However, I've identified a critical issue where the changes to method signatures break existing tests, which must be addressed to ensure the correctness of this fix. Please see the detailed comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the frontend server-related changes too.
No problem! Couldn't land this roll without them, unfortunately 😅 At least they were simple to migrate! |
autosubmit label was removed for flutter/flutter/176808, because - The status or check suite Mac_x64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/176808, because - The status or check suite Windows tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/176808, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Fixes dart-lang/sdk#61560