Support RTL Cupertino nav bar transitions between routes #23221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Oct 18, 2018
| @@ -1528,7 +1532,8 @@ class _NavigationBarComponentsTransition { | |||
| topLargeExpanded = topNavBar.largeExpanded, | |||
| transitionBox = | |||
| // paintBounds are based on offset zero so it's ok to expand the Rects. | |||
| bottomNavBar.renderBox.paintBounds.expandToInclude(topNavBar.renderBox.paintBounds); | |||
| bottomNavBar.renderBox.paintBounds.expandToInclude(topNavBar.renderBox.paintBounds), | |||
| forwardDirection = directionality == TextDirection.ltr ? 1.0 : -1.0; | |||
There was a problem hiding this comment.
test for rtl rather than ltr, that way in the unlikely event that we add a value to TextDirection, this will fail more obviously for us people who use LTR.
There was a problem hiding this comment.
my math is likely failing me but I don't think there's a concise way of arranging this such that on a new enum value, the ltr outcome ends up with a wrong / non-1.0 value is there?
Hixie
reviewed
Oct 18, 2018
| await tester.pump(const Duration(milliseconds: 150)); | ||
|
|
||
| checkOpacity( | ||
| tester, flying(tester, find.text('Page 2')), 0.6753286570310593); |
There was a problem hiding this comment.
there's no need to wrap here, but if you do, use flutter style wrapping so it's easier to see where the expression ends.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9446