Almost enable always_specify_types lint #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix the zillion issues that uncovered.
| @@ -321,7 +321,7 @@ class StockHomeState extends State<StockHome> { | |||
| } | |||
|
|
|||
| void _handleCreateCompany() { | |||
| showModalBottomSheet( | |||
| showModalBottomSheet/*<int, double>*/( // XXXXXX DO NOT CHECK IN XXXXXX THIS IS A CHECK OF THE ANALYZER | |||
There was a problem hiding this comment.
the fact that this didn't go off is worrying
|
RSLGTM |
Hixie
added a commit
that referenced
this pull request
Mar 12, 2016
Almost enable always_specify_types lint
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Mar 12, 2016
This reverts commit f41b341, reversing changes made to e33d8d9. This was a bad check-in due to my mangling uploading a new version of the branch from a different machine. This reverts flutter#2639 and will be replaced by flutter#2640
Hixie
added a commit
that referenced
this pull request
Mar 12, 2016
Revert "Merge pull request #2639 from Hixie/always_specify_types"
TahaTesser
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the zillion issues that uncovered, but this isn't done yet. Still a few hundred to deal with. I just wanted to get this out for review so I can land this work in progress before the rename fixit.
cc @abarth