Skip to content

[Gallery] Fortnightly demo moved from flutter/samples. #28125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 24, 2019
Merged

[Gallery] Fortnightly demo moved from flutter/samples. #28125

merged 20 commits into from
Feb 24, 2019

Conversation

willlarche
Copy link
Contributor

@willlarche willlarche commented Feb 19, 2019 •
edited
Loading

Requires github.com/flutter/flutter_gallery_assets/pull/33

Includes minor changes to better work with the gallery.

simulator screen shot - iphone xs max - 2019-02-19 at 10 36 02
simulator screen shot - iphone xs max - 2019-02-18 at 20 39 40

@zoechi zoechi added c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Feb 19, 2019
rami-a
rami-a approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clocksmith
Copy link
Contributor

LGTM

@willlarche
Copy link
Contributor Author

Failing right now because of packages dep https://github.com/flutter/flutter_gallery_assets/pull/33

HansMuller
HansMuller reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small stuff

@willlarche
Copy link
Contributor Author

@HansMuller , am I safe to do a force upgrade for the packages these days?

HansMuller
HansMuller reviewed Feb 20, 2019
View reviewed changes
@HansMuller
Copy link
Contributor

A force-upgrade in the flutter-repo is never safe. Is it necessary?

@willlarche
Copy link
Contributor Author

The instructions say it is

  # To change the version of the gallery assets, edit
  #   //packages/flutter_tools/lib/src/commands/update_packages.dart
  # and run
  #   flutter update-packages --force-upgrade

But of course that updates Pedantic too.

@willlarche willlarche force-pushed the feature-study-fortnightly branch 2 times, most recently from fd7b6fe to e09d825 Compare February 22, 2019 20:31
@willlarche
Copy link
Contributor Author

Whitespace detected at the end of source code lines. I guess I'll move spaces to the beginning of the lines.

@willlarche willlarche mentioned this pull request Feb 22, 2019
Closed
HansMuller
HansMuller approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willlarche willlarche force-pushed the feature-study-fortnightly branch from e17b72a to 9f0fe5e Compare February 23, 2019 22:17
@willlarche willlarche merged commit 57a8b03 into flutter:master Feb 24, 2019
@willlarche willlarche mentioned this pull request Feb 25, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clocksmith clocksmith clocksmith approved these changes

@HansMuller HansMuller HansMuller approved these changes

@rami-a rami-a rami-a approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@willlarche @clocksmith @HansMuller @rami-a @zoechi @googlebot