Skip to content

Fuschia -> Fuchsia #28482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

Fuschia -> Fuchsia #28482

merged 2 commits into from
Feb 26, 2019

Conversation

goderbauer
Copy link
Member

Description

Renames raw_keyboard_fuschia.dart to raw_keyboard_fuchsia.dart (note position of S).

Related Issues

Fixes #28475.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

cbracken
cbracken approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit 1e5992a into flutter:master Feb 26, 2019
@zoechi zoechi added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 26, 2019
@goderbauer goderbauer deleted the fuschia branch March 30, 2019 07:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The .../src/services/raw_keyboard_fuschia.dart filename misspells fuchsia
5 participants
@goderbauer @cbracken @gspencergoog @zoechi @googlebot