Skip to content

Conversation

darrenaustin
Copy link
Contributor

Description

We weren't disposing of an AnimationController in the material DataPicker implementation. This could lead to leaking a ticker when the picker was dismissed. This should take care of the exception mentioned in #32628.

Related Issues

Addresses the stack trace in #32628.

Tests

No changes to the tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: date/time picker Date or time picker widgets labels May 16, 2019
@darrenaustin darrenaustin merged commit 8c05e8c into flutter:master May 17, 2019
@darrenaustin darrenaustin deleted the date_picker_animation_leak branch May 17, 2019 00:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants