Fixed for DropdownButton crashing when a style was used that didn't include a fontSize #33474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat didn't include a fontSize.
darrenaustin
added
framework
HansMuller
approved these changes
May 29, 2019
| @@ -795,7 +795,8 @@ class _DropdownButtonState<T> extends State<DropdownButton<T>> with WidgetsBindi | |||
| // Similarly, we don't reduce the height of the button so much that its icon | |||
| // would be clipped. | |||
| double get _denseButtonHeight { | |||
| return math.max(_textStyle.fontSize, math.max(widget.iconSize, _kDenseButtonHeight)); | |||
| final double fontSize = _textStyle.fontSize ?? Theme.of(context).textTheme.subhead.fontSize; | |||
There was a problem hiding this comment.
This might be a little clearer as: ... widget.style.fontSize ?? Theme.of(context)...
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
…nclude a fontSize (flutter#33474) Fixed an issue with a DropdownButton crashing when a style was used that didn't include a fontSize.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
styleparameter to aDropdownButtondidn't specify afontSizewe weren't falling back and using thefontSizefrom the theme's subhead. This PR fixes that and adds a test for it.Related Issues
Fixes: #33425
Tests
I added a test to ensure we don't crash with this configuration.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?