Skip to content

Unmark flutter_gallery__back_button_memory as flaky #33861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

Unmark flutter_gallery__back_button_memory as flaky #33861

merged 1 commit into from
Jun 4, 2019

Conversation

GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jun 4, 2019

This test is no longer particularly flaky.

@GaryQian GaryQian requested a review from tvolkert June 4, 2019 18:04
@GaryQian GaryQian added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 4, 2019
goderbauer
goderbauer approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryQian GaryQian merged commit e0cb468 into flutter:master Jun 4, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaryQian @goderbauer @tvolkert @googlebot