Skip to content

'the the' doc fix #33917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

'the the' doc fix #33917

merged 1 commit into from
Jun 5, 2019

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 5, 2019 •
edited
Loading

Description

Removes redundant 'the's from documentation

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. labels Jun 5, 2019
@shihaohong shihaohong self-requested a review June 5, 2019 15:55
shihaohong
shihaohong approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm surprised (and also not surprised) how many "the the"s there are :)

@gspencergoog
Copy link
Contributor

Here's another one.

@Piinks
Copy link
Contributor Author

Piinks commented Jun 5, 2019

I'm going to land this on red to get the build green again.

@Piinks Piinks merged commit 5a6a664 into flutter:master Jun 5, 2019
@Piinks Piinks deleted the docFix branch July 9, 2019 17:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Piinks @gspencergoog @shihaohong @googlebot