Skip to content

rename the test app android_views to platform_views #36384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 17, 2019
Merged

rename the test app android_views to platform_views #36384

merged 18 commits into from
Jul 17, 2019

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jul 17, 2019 •
edited
Loading

Description

Renaming the test app so it makes more sense when adding the iOS tests.
Follow up #36200

Renaming the folder will make the PR look ugly, so will rename the folder in a follow up PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 17, 2019
@cyanglaz cyanglaz requested a review from amirh July 17, 2019 17:25
amirh
amirh approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dev/integration_tests/android_views/pubspec.yaml Outdated
@@ -1,4 +1,4 @@
name: android_views
name: platform_views
description: An integration test for embedded Android views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update the description as well.

@cyanglaz cyanglaz merged commit 7a4665f into flutter:master Jul 17, 2019
@cyanglaz cyanglaz deleted the platform_view_test_rename2 branch July 17, 2019 20:57
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@johnsonmh
Rename the test app android_views to platform_views (flutter#36384)
382f106
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@amirh amirh amirh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyanglaz @amirh @googlebot @fluttergithubbot