Skip to content

add missing trailing commas (in dev/) #40704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

add missing trailing commas (in dev/) #40704

merged 1 commit into from
Sep 19, 2019

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Sep 17, 2019

Description

add missing trailing commas (in dev/)

Related Issues

None

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 17, 2019
@a14n a14n added the framework flutter/packages/flutter repository. See also f: labels. label Sep 17, 2019
goderbauer
goderbauer approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zazo032
Zazo032 reviewed Sep 17, 2019
View reviewed changes
dev/automated_tests/flutter_test/print_user_created_ancestor_test.dart
@@ -12,7 +12,7 @@ void main() {
CustomScrollView(
slivers: <Widget>[
SliverToBoxAdapter(child: Container()),
]
],
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also missing another trailing comma?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Actually my current lint rule is not enough aggressive to catch it. I'll try to catch more cases in another PR.

@a14n a14n merged commit a36f809 into flutter:master Sep 19, 2019
@a14n a14n deleted the prefer_trailing_commas-dev branch September 19, 2019 05:54
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@a14n @Inconnu08
add missing trailing commas (in dev/) (flutter#40704)
f192416
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@Zazo032 Zazo032 Zazo032 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a14n @goderbauer @Zazo032 @googlebot @fluttergithubbot