Reland text state #47464
Merged
Reland text state #47464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
a: tests
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relands the parts of #47177 that updated the way the tester handles text editing state, and adds a new test to make sure we don't re-introduce the regression I accidentally introduced into that patch.
The original change in that patch created a race and unclear ownership of the editing state between the platform and framework. Espresso tests uncovered this by entering text very very rapidly and failing to get the expected results. The real fix will have to use some other method to send framework side state to the platform.
I'll be following this up with another patch to fix the original issue #47177 was addressing, but we want this change in here anyway.
This relands a breaking change - the migration guide is here: https://flutter.dev/docs/release/breaking-changes/test-text-input
I'll have to tweak that guide a bit since the breakage is no longer about setEditingState.
/cc @chingjun FYI