Skip to content

ToDo Audit - Cupertino+ Library #54798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2020
Merged

ToDo Audit - Cupertino+ Library #54798

merged 4 commits into from
Apr 22, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 14, 2020 •
edited
Loading

Description

Continuing an audit of TODOs in the code base.

Related Issues

#55409
#55411
#12286
#19786
#19783

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 14, 2020
Piinks
Piinks commented Apr 21, 2020
View reviewed changes
Piinks
Piinks commented Apr 21, 2020
View reviewed changes
@Piinks Piinks marked this pull request as ready for review April 22, 2020 22:31
@Piinks
Copy link
Contributor Author

Piinks commented Apr 22, 2020

This is ready for review. :)

@Piinks Piinks changed the title [WIP] Todo Audit - Cupertino+ Library ToDo Audit - Cupertino+ Library Apr 22, 2020
goderbauer
goderbauer approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit cbc121e into flutter:master Apr 22, 2020
@Piinks Piinks mentioned this pull request Jun 5, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster xster left review comments

@goderbauer goderbauer goderbauer approved these changes

+2 more reviewers

@dnfield dnfield dnfield left review comments

@shihaohong shihaohong shihaohong left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Piinks @xster @goderbauer @dnfield @shihaohong @googlebot @fluttergithubbot