Skip to content

Revert "Bring back paste button hide behavior" #56806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2020
Merged

Revert "Bring back paste button hide behavior" #56806

merged 1 commit into from
May 10, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented May 10, 2020

Reverts #56689.

This broke many widget tests in g3 with:

A ClipboardStatusNotifier was used after being disposed.
Once you have called dispose() on a ClipboardStatusNotifier, it
can no longer be used.

Justin will investigate next week. Till then, let's revert.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 10, 2020
@mehmetf
Copy link
Contributor Author

mehmetf commented May 10, 2020

TBR @justinmc

@mehmetf mehmetf merged commit 0786f29 into master May 10, 2020
@mehmetf mehmetf deleted the revert-56689-pasteable-revert-revert branch May 10, 2020 03:22
justinmc added a commit to justinmc/flutter that referenced this pull request May 11, 2020
@justinmc
Revert "Revert "Bring back paste button hide behavior (flutter#56689)" (
23f1aca 
flutter#56806)"

This reverts commit 0786f29.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetf @googlebot @fluttergithubbot