-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Support .flutter-plugins-dependencies #59209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .flutter-plugins-dependencies #59209
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@@ -2,6 +2,8 @@ | |||
# Use of this source code is governed by a BSD-style license that can be | |||
# found in the LICENSE file. | |||
|
|||
require 'json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby std lib module available since Ruby 0.4, CocoaPods depends on it, safe to use here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a nit about linking in comment to flutter.dev/go/plugins-list-migration
Description
Parse
.flutter-plugins-dependencies
instead of the old.flutter-plugins
to only embed theios
-enabled plugins via CocoaPods..flutter-plugins
was a flat list of all plugins and their pub cache path, regardless of supported platform:.flutter-plugins-dependencies
is json:See https://docs.google.com/document/d/1W_IpXetVIgjHipKnu-zPHnDApdiwXR0RfugY6Sm8NAg/edit
Related Issues
Fixes #39659
Tests
Updated integration test to test a plugin that doesn't support iOS.
Checklist
///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change