InteractiveViewer mouse scale bug #59478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
LongCatIsLooong
approved these changes
Jun 15, 2020
| @@ -659,13 +659,13 @@ class _InteractiveViewerState extends State<InteractiveViewer> with TickerProvid | |||
|
|
|||
| // Returns true iff the given _GestureType is enabled. | |||
| bool _gestureIsSupported(_GestureType gestureType) { | |||
| if (_gestureType == _GestureType.pan && !widget.panEnabled) { | |||
| if (gestureType == _GestureType.pan && !widget.panEnabled) { | |||
There was a problem hiding this comment.
nit: maybe use switch instead?
There was a problem hiding this comment.
That seems simpler to me, will do 👍
There was a problem hiding this comment.
I think using default clause is discouraged.
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
InteractiveViewer wasn't respecting the
scaleEnabledparameter when scaling was done with a mouse.Related Issues
Closes #59411
Tests
I added the following tests:
scaleEnabledis false.Breaking Change
None