Skip to content

Use ephemeral ports for iOS port forwarding #60381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

Use ephemeral ports for iOS port forwarding #60381

merged 1 commit into from
Jun 26, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 26, 2020

Description

Get an available socket, only try again in the ephemeral port range.

Related Issues

Fixes #59333

Tests

Updated ios_device_port_forwarder_test.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the platform-ios iOS applications specifically label Jun 26, 2020
@jmagman jmagman requested a review from zanderso June 26, 2020 19:02
@jmagman jmagman self-assigned this Jun 26, 2020
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 26, 2020
@flutter-github-sync
Copy link

Started Google testing for this PR

@flutter-github-sync
Copy link

Google testing passed!

@jmagman jmagman merged commit a4fa61b into flutter:master Jun 26, 2020
@jmagman jmagman deleted the ephemeral branch June 26, 2020 22:02
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Use ephemeral ports for iOS port forwarding (flutter#60381)
98bc96c
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS port forwarder should try ephemeral ports for host port.
5 participants
@jmagman @flutter-github-sync @zanderso @googlebot @fluttergithubbot