Skip to content

Remove unused optional parameters of private functions. #60446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

srawlins
Copy link
Contributor

Description

Remove unused optional parameters of private functions.

This is required to enable checking for unused optional parameters of private
functions. dart-lang/sdk#29731

Related Issues

Tests

I added no tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 27, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @srawlins! it looks like the analyzer is unhappy here, can you take a look? :)

srawlins added 3 commits July 6, 2020 16:06
This is required to enable checking for unused optional parameters of private
functions. dart-lang/sdk#29731
@srawlins srawlins force-pushed the unused-parametersd branch from 2115a6e to f22341f Compare July 7, 2020 22:49
@srawlins
Copy link
Contributor Author

srawlins commented Jul 8, 2020

I pushed a commit, and I think analyze-linux is now failing on some unrelated thing.

@Piinks
Copy link
Contributor

Piinks commented Jul 8, 2020

I pushed a commit, and I think analyze-linux is now failing on some unrelated thing.

Right you are. The issues with url_launcher in the analyzer failure was a break on master yesterday. They have been resolved now, so updating with the latest from master should clear it up. :)

@srawlins
Copy link
Contributor Author

I think good to go!

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit 54f99d6 into flutter:master Jul 15, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants