-
Notifications
You must be signed in to change notification settings - Fork 29k
Remove unused optional parameters of private functions. #60446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @srawlins! it looks like the analyzer is unhappy here, can you take a look? :)
This is required to enable checking for unused optional parameters of private functions. dart-lang/sdk#29731
2115a6e
to
f22341f
Compare
I pushed a commit, and I think analyze-linux is now failing on some unrelated thing. |
Right you are. The issues with url_launcher in the analyzer failure was a break on master yesterday. They have been resolved now, so updating with the latest from master should clear it up. :) |
I think good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Remove unused optional parameters of private functions.
This is required to enable checking for unused optional parameters of private
functions. dart-lang/sdk#29731
Related Issues
Tests
I added no tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.