Skip to content

Skip Audit - Widgets Library #60936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2020
Merged

Skip Audit - Widgets Library #60936

merged 6 commits into from
Jul 9, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 6, 2020 •
edited
Loading

Description

Skipped test audit for the widgets library.
Turns on 46 tests that were previously being skipped, the rest have been labelled with an associated issue.
This also removes 17 TODOs to deflate the tech debt benchmark (TODOs with skips meant double counting)

Related Issues

#58841 - audit tracking issue
#7919
#35347
#57187
#54292
#5339
#4771
#42767
#43694
#44152
#42086
#20891
#33523
#44020

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Jul 6, 2020
@Piinks Piinks added a: quality A truly polished experience a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 7, 2020
@Piinks Piinks marked this pull request as ready for review July 8, 2020 21:09
@Piinks Piinks changed the title [WIP] Skip Audit - Widgets Library Skip Audit - Widgets Library Jul 8, 2020
@Piinks Piinks requested a review from goderbauer July 8, 2020 21:15
@goderbauer
Copy link
Member

nit: analyzer is unhappy about unused imports.

goderbauer
goderbauer approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit debb3a5 into flutter:master Jul 9, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@Piinks @mingwandroid
Skip Audit - Widgets Library (flutter#60936)
8ec65d3
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: quality A truly polished experience a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Piinks @goderbauer @googlebot @fluttergithubbot